fix(noUndeclaredVariables): consult embedded bindings service before flagging false positives (#9269)

Author: dyc3

.changeset/fix-no-undeclared-vue-bindings.md

@@ -0,0 +1,7 @@
+---
+"@biomejs/biome": patch
+---
+
+Fixed a false positive where `noUndeclaredVariables` reported bindings from Vue `<script setup>` as undeclared when used in `<template>`.
+
+This change ensures embedded bindings collected from script snippets (like imports and `defineModel` results) are respected by the rule.

crates/biome_cli/tests/cases/handle_vue_files.rs

@@ -1687,3 +1687,44 @@ let counter = 0;
         result,
  ));
 }
+
+#[test]
+fn no_undeclared_variables_not_triggered_for_script_setup_bindings() {
+ let fs = MemoryFileSystem::default();
+ let mut console = BufferConsole::default();
+
+    fs.insert(
+ "biome.json".into(),
+ r#"{ "html": { "linter": {"enabled": true}, "experimentalFullSupportEnabled": true } }"#
+ .as_bytes(),
+ );
+
+ let file = Utf8Path::new("file.vue");
+    fs.insert(
+        file.into(),
+ r#"<script setup lang="ts">
+import { ALL_SKIP_CATEGORIES } from "ott-common";
+const model = defineModel<string[]>();
+</script>
+<template>
+  <div :data-categories="ALL_SKIP_CATEGORIES">{{ model }}</div>
+</template>"#
+ .as_bytes(),
+ );
+
+ let (fs, result) = run_cli(
+        fs,
+ &mut console,
+ Args::from(["lint", "--only=noUndeclaredVariables", file.as_str()].as_slice()),
+ );
+
+ assert!(result.is_ok(), "run_cli returned {result:?}");
+
+ assert_cli_snapshot(SnapshotPayload::new(
+ module_path!(),
+ "no_undeclared_variables_not_triggered_for_script_setup_bindings",
+        fs,
+        console,
+        result,
+ ));
+}

crates/biome_cli/tests/snapshots/main_cases_handle_vue_files/no_undeclared_variables_not_triggered_for_script_setup_bindings.snap

@@ -0,0 +1,32 @@
+---
+source: crates/biome_cli/tests/snap_test.rs
+expression: redactor(content)
+---
+## `biome.json`
+
+```json
+{
+ "html": {
+ "linter": { "enabled": true },
+ "experimentalFullSupportEnabled": true
+  }
+}
+```
+
+## `file.vue`
+
+```vue
+<script setup lang="ts">
+import { ALL_SKIP_CATEGORIES } from "ott-common";
+const model = defineModel<string[]>();
+</script>
+<template>
+  <div :data-categories="ALL_SKIP_CATEGORIES">{{ model }}</div>
+</template>
+```
+
+# Emitted Messages
+
+```block
+Checked 1 file in <TIME>. No fixes applied.
+```

crates/biome_js_analyze/src/lint/correctness/no_undeclared_variables.rs

@@ -1,4 +1,5 @@
 use crate::globals::{is_js_global, is_ts_global};
+use crate::services::embedded_bindings::EmbeddedBindings;
 use crate::services::semantic::SemanticServices;
 use biome_analyze::context::RuleContext;
 use biome_analyze::{Rule, RuleDiagnostic, RuleSource, declare_lint_rule};
@@ -86,6 +87,13 @@ impl Rule for NoUndeclaredVariables {
  return None;
  }
 
+ let embedded_bindings = ctx
+ .get_service::<EmbeddedBindings>()
+ .expect("embedded bindings service");
+ if embedded_bindings.contains_binding(text) {
+ return None;
+ }
+
  // Typescript Const Assertion
  if text == "const" && under_as_expression {
  return None;