Skip to content
This repository was archived by the owner on May 12, 2026. It is now read-only.

feat: Add GDCH support - #1087

Merged
poanc merged 27 commits into
googleapis:mainfrom
poanc:gdch
Dec 6, 2022
Merged

feat: Add GDCH support#1087
poanc merged 27 commits into
googleapis:mainfrom
poanc:gdch

Conversation

@poanc

@poanc poanc commented Nov 9, 2022

Copy link
Copy Markdown
Contributor

Add support for GDCH in Java. See the Java implementation design doc for more detail: go/gdch-java-auth-lib.

GDCH for auth lib design doc and Python implementation could be found in go/gdch-python-auth-lib.

Fixes #960

@poanc poanc added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 9, 2022
@poanc
poanc requested review from a team and TimurSadykov November 9, 2022 20:43
@product-auto-label product-auto-label Bot added the size: xl Pull request size is extra large. label Nov 9, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 9, 2022
@poanc poanc closed this Nov 10, 2022
@poanc
poanc deleted the gdch branch November 10, 2022 19:22
@poanc
poanc restored the gdch branch November 10, 2022 19:22
@poanc poanc reopened this Nov 10, 2022

@TimurSadykov TimurSadykov left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments, not finished yet

Comment thread oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Outdated
Comment thread oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Outdated
Comment thread oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Outdated
Comment thread oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Outdated
Comment thread oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Outdated
Comment thread oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Outdated
Comment thread oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Outdated
Comment thread oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Outdated
Comment thread oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Outdated
Comment thread oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Outdated
Comment thread oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Outdated
Comment thread oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java
Comment thread oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java
Comment thread oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java
Comment thread oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java
Comment thread oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Outdated
Comment thread oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java
Comment thread oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java
@poanc
poanc requested a review from a team November 17, 2022 05:29
@poanc poanc changed the title feat: add GDCH support feat: Add GDCH support Nov 29, 2022
Comment thread oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java
Comment thread oauth2_http/java/com/google/auth/oauth2/OAuth2Utils.java

@TimurSadykov TimurSadykov left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small comments and a question

@TimurSadykov TimurSadykov left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

Comment thread oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Outdated
Comment thread oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java
@TimurSadykov
TimurSadykov requested review from blakeli0 and ddixit14 and removed request for ddixit14 December 5, 2022 10:18
Comment thread oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java Outdated

@arithmetic1728 arithmetic1728 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: xl Pull request size is extra large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement GDCH support

5 participants