feat: Convert internal interfaces to use protos - #1335
Merged
Conversation
dpcollins-google
force-pushed
the
internals-use-protos
branch
from
February 20, 2023 01:34
07c5dbf to
43d2ef5
Compare
tmdiep
approved these changes
Feb 20, 2023
dpcollins-google
force-pushed
the
internals-use-protos
branch
from
February 20, 2023 05:09
3f538b6 to
b8148ec
Compare
|
This change breaks the compatibility with "com.google.cloud:pubsublite-spark-sql-streaming:1.0.0" which uses non-proto SequencedMessage ( ref: https://github.com/googleapis/java-pubsublite-spark/blob/main/src/main/java/com/google/cloud/pubsublite/spark/PslReadDataSourceOptions.java ) on ref: googleapis/java-pubsublite-spark#637 (comment) for more detail on exception you would get due to this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.