Skip to content

Vulkan: Fix disabling VSync on SDL platforms that support IMMEDIATE but not MAILBOX#18087

Merged
hrydgard merged 1 commit into
masterfrom
vsync-immediate-fix
Sep 7, 2023
Merged

Vulkan: Fix disabling VSync on SDL platforms that support IMMEDIATE but not MAILBOX#18087
hrydgard merged 1 commit into
masterfrom
vsync-immediate-fix

Conversation

@hrydgard

@hrydgard hrydgard commented Sep 6, 2023

Copy link
Copy Markdown
Owner

This includes Mac M1.

Also allow IMMEDIATE and ignore FIFO_RELAXED on Android - the latter is simply not ever supported. Well, IMMEDIATE isn't supported much either on Android but its semantics are clearer than FIFO_RELAXED.

Fixes #18084

@hrydgard hrydgard added SDL Issue on SDL (or Qt in SDL code) but not all ports. Vulkan labels Sep 6, 2023
@hrydgard hrydgard added this to the v1.16.0 milestone Sep 6, 2023
@hrydgard hrydgard merged commit 942a1c0 into master Sep 7, 2023
@hrydgard hrydgard deleted the vsync-immediate-fix branch September 7, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

SDL Issue on SDL (or Qt in SDL code) but not all ports. Vulkan

Projects

None yet

Development

Successfully merging this pull request may close these issues.

On Mac with Vulkan (MoltenVK), setting VSync to off still gets stuck in FIFO mode

1 participant