(code review) remove redundant check for empty collection

guusdk · guusdk · commit 3332aec459a9 · 2026-05-19T16:21:33.000+02:00
diff --git a/xmppserver/src/main/java/org/jivesoftware/openfire/session/LocalClientSession.java b/xmppserver/src/main/java/org/jivesoftware/openfire/session/LocalClientSession.java
@@ -966,11 +966,7 @@ static void returnPrivacyListErrorToSender(Packet packet) {
     @Override
     public void deliver(Packet queueOrPushStanza) throws UnauthorizedException
     {
-        final List<Packet> stanzasToPush = csiManager.queueOrPush(queueOrPushStanza);
-        if (stanzasToPush.isEmpty()) {
-            return;
-        }
-        pushPackets(stanzasToPush);
+        pushPackets(csiManager.queueOrPush(queueOrPushStanza));
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -966,11 +966,7 @@ static void returnPrivacyListErrorToSender(Packet packet) {`
`966`	`966`	`@Override`
`967`	`967`	`public void deliver(Packet queueOrPushStanza) throws UnauthorizedException`
`968`	`968`	`{`
`969`		`- final List<Packet> stanzasToPush = csiManager.queueOrPush(queueOrPushStanza);`
`970`		`- if (stanzasToPush.isEmpty()) {`
`971`		`- return;`
`972`		`- }`
`973`		`- pushPackets(stanzasToPush);`
	`969`	`+ pushPackets(csiManager.queueOrPush(queueOrPushStanza));`
`974`	`970`	`}`
`975`	`971`
`976`	`972`	`/**`