Skip to content

Commit d599b68

Browse files
feat: [UIE-9357] - refactor
1 parent 189e47f commit d599b68

5 files changed

Lines changed: 6 additions & 15 deletions

File tree

packages/manager/src/features/IAM/Shared/AssignedRolesTable/ChangeRoleDrawer.tsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,7 @@ export const ChangeRoleDrawer = ({ mode, onClose, open, role }: Props) => {
6161
const assignedRoles = isDefaultDelegationRolesForChildAccount
6262
? defaultRolesData
6363
: userRolesData;
64-
const { mutateAsync: updateUserRoles } = useUserRolesMutation(
65-
username,
66-
Boolean(username)
67-
);
64+
const { mutateAsync: updateUserRoles } = useUserRolesMutation(username);
6865

6966
const { mutateAsync: updateDefaultRoles } =
7067
useUpdateDefaultDelegationAccessQuery();

packages/manager/src/features/IAM/Shared/AssignedRolesTable/UnassignRoleConfirmationDialog.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ export const UnassignRoleConfirmationDialog = (props: Props) => {
4646
isPending,
4747
mutateAsync: updateUserRoles,
4848
reset,
49-
} = useUserRolesMutation(username, Boolean(username));
49+
} = useUserRolesMutation(username);
5050

5151
const { mutateAsync: updateDefaultRoles, isPending: isDefaultRolesPending } =
5252
useUpdateDefaultDelegationAccessQuery();

packages/manager/src/features/IAM/Shared/AssignedRolesTable/UpdateEntitiesDrawer.tsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,7 @@ export const UpdateEntitiesDrawer = ({ onClose, open, role }: Props) => {
4242
const assignedRoles = isDefaultDelegationRolesForChildAccount
4343
? defaultRolesData
4444
: userRolesData;
45-
const { mutateAsync: updateUserRoles } = useUserRolesMutation(
46-
username,
47-
Boolean(username)
48-
);
45+
const { mutateAsync: updateUserRoles } = useUserRolesMutation(username);
4946

5047
const { mutateAsync: updateDefaultRoles } =
5148
useUpdateDefaultDelegationAccessQuery();

packages/manager/src/features/IAM/Users/UserRoles/AssignNewRoleDrawer.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ export const AssignNewRoleDrawer = ({
9999
}, [accountRoles, assignedRoles]);
100100

101101
const { mutateAsync: updateUserRoles, isPending: isUserRolesPending } =
102-
useUserRolesMutation(username, Boolean(username));
102+
useUserRolesMutation(username);
103103

104104
const { mutateAsync: updateDefaultRoles, isPending: isDefaultRolesPending } =
105105
useUpdateDefaultDelegationAccessQuery();

packages/queries/src/iam/iam.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,7 @@ export const useAccountRoles = (enabled = true) => {
3030
});
3131
};
3232

33-
export const useUserRolesMutation = (
34-
username?: string,
35-
enabled: boolean = true,
36-
) => {
33+
export const useUserRolesMutation = (username: string | undefined) => {
3734
const queryClient = useQueryClient();
3835

3936
return useMutation<IamUserRoles, APIError[], IamUserRoles>({
@@ -44,7 +41,7 @@ export const useUserRolesMutation = (
4441
return updateUserRoles(username, data);
4542
},
4643
onSuccess: (role) => {
47-
if (username && enabled) {
44+
if (username) {
4845
queryClient.setQueryData<IamUserRoles>(
4946
iamQueries.user(username)._ctx.roles.queryKey,
5047
role,

0 commit comments

Comments
 (0)