Skip to content

Commit a8d229e

Browse files
authored
[Main][Task]31233527:Change Default RequestSizeLimitBytes (#2501)
* add post channel config * update * udpate * update * update * update * udpate * update * update * update
1 parent 10053b1 commit a8d229e

8 files changed

Lines changed: 151 additions & 128 deletions

File tree

AISKU/Tests/Unit/src/AISKUSize.Tests.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,8 @@ function _checkSize(checkType: string, maxSize: number, size: number, isNightly:
5454
}
5555

5656
export class AISKUSizeCheck extends AITestClass {
57-
private readonly MAX_RAW_SIZE = 145;
58-
private readonly MAX_BUNDLE_SIZE = 145;
57+
private readonly MAX_RAW_SIZE = 146;
58+
private readonly MAX_BUNDLE_SIZE = 146;
5959
private readonly MAX_RAW_DEFLATE_SIZE = 58;
6060
private readonly MAX_BUNDLE_DEFLATE_SIZE = 58;
6161
private readonly rawFilePath = "../dist/es5/applicationinsights-web.min.js";

AISKULight/Tests/Unit/src/AISKULightSize.Tests.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@ function _checkSize(checkType: string, maxSize: number, size: number, isNightly:
5151
}
5252

5353
export class AISKULightSizeCheck extends AITestClass {
54-
private readonly MAX_RAW_SIZE = 91;
55-
private readonly MAX_BUNDLE_SIZE = 91;
54+
private readonly MAX_RAW_SIZE = 92;
55+
private readonly MAX_BUNDLE_SIZE = 92;
5656
private readonly MAX_RAW_DEFLATE_SIZE = 38;
5757
private readonly MAX_BUNDLE_DEFLATE_SIZE = 38;
5858
private readonly rawFilePath = "../dist/es5/applicationinsights-web-basic.min.js";

channels/1ds-post-js/src/HttpManager.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -774,7 +774,7 @@ export class HttpManager {
774774

775775
// Make sure we have a payload object
776776
thePayload = thePayload || _serializer.createPayload(retryCount, isTeardown, isSynchronous, isReducedPayload, sendReason, sendType);
777-
777+
778778
// Add the batch to the current payload
779779
if (!_serializer.appendPayload(thePayload, theBatch, maxEventsPerBatch)) {
780780
// Entire batch was not added so send the payload and retry adding this batch

channels/1ds-post-js/src/Serializer.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,8 @@ import { mathMin, strSubstr } from "@nevware21/ts-utils";
3030
*/
3131
const _MAX_STRING_JOINS = 20;
3232

33-
const RequestSizeLimitBytes = 3984588; // approx 3.8 Mb
33+
// Max Size set by One Collector: https://msazure.visualstudio.com/OneDsCollector/_git/Collector?path=/Services/Azure/CollectorWorkerRoleAzure/ServiceConfiguration.Cloud.cscfg
34+
const RequestSizeLimitBytes = 3145728; // approx 3.15 Mb
3435
const BeaconRequestSizeLimitBytes = 65000; // approx 64kb (the current Edge, Firefox and Chrome max limit)
3536
const MaxRecordSize = 2000000; // approx 2 Mb
3637
const MaxBeaconRecordSize = mathMin(MaxRecordSize, BeaconRequestSizeLimitBytes);

common/config/rush/npm-shrinkwrap.json

Lines changed: 140 additions & 118 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

extensions/applicationinsights-analytics-js/Tests/Unit/src/AnalyticsExtensionSize.tests.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ function _checkSize(checkType: string, maxSize: number, size: number, isNightly:
5151
}
5252

5353
export class AnalyticsExtensionSizeCheck extends AITestClass {
54-
private readonly MAX_DEFLATE_SIZE = 24;
54+
private readonly MAX_DEFLATE_SIZE = 25;
5555
private readonly rawFilePath = "../dist/es5/applicationinsights-analytics-js.min.js";
5656
private readonly prodFilePaath = "../browser/es5/applicationinsights-analytics-js.min.js"
5757

shared/1ds-core-js/test/Unit/src/FileSizeCheckTest.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ function _checkSize(checkType: string, maxSize: number, size: number, isNightly:
5151
}
5252

5353
export class FileSizeCheckTest extends AITestClass {
54-
private readonly MAX_BUNDLE_SIZE = 68;
54+
private readonly MAX_BUNDLE_SIZE = 69;
5555
private readonly MAX_DEFLATE_SIZE = 29;
5656
private readonly bundleFilePath = "../bundle/es5/ms.core.min.js";
5757

shared/AppInsightsCore/Tests/Unit/src/AppInsightsCoreSize.Tests.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@ function _checkSize(checkType: string, maxSize: number, size: number, isNightly:
5151
}
5252

5353
export class AppInsightsCoreSizeCheck extends AITestClass {
54-
private readonly MAX_RAW_SIZE = 65;
55-
private readonly MAX_BUNDLE_SIZE = 65;
54+
private readonly MAX_RAW_SIZE = 67;
55+
private readonly MAX_BUNDLE_SIZE = 67;
5656
private readonly MAX_RAW_DEFLATE_SIZE = 28;
5757
private readonly MAX_BUNDLE_DEFLATE_SIZE = 28;
5858
private readonly rawFilePath = "../dist/es5/applicationinsights-core-js.min.js";

0 commit comments

Comments
 (0)