Skip to content

Commit 042bf8f

Browse files
committed
Mark suitable methods as static
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
1 parent 8d6e64f commit 042bf8f

4 files changed

Lines changed: 14 additions & 7 deletions

File tree

whipper/command/mblookup.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@ def add_arguments(self):
1818
help="MusicBrainz Disc ID or Release ID to look up"
1919
)
2020

21-
def _printMetadata(self, md):
21+
@staticmethod
22+
def _printMetadata(md):
2223
"""
2324
Print out metadata received in a sensible way.
2425

whipper/common/encode.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,8 @@ def start(self, runner):
103103
task.Task.start(self, runner)
104104
self.schedule(0.0, self._embed_picture)
105105

106-
def _make_flac_picture(self, cover_art_filename):
106+
@staticmethod
107+
def _make_flac_picture(cover_art_filename):
107108
"""
108109
Given a path to a jpg/png file, return a FLAC picture for embedding.
109110

whipper/common/program.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,8 @@ def setWorkingDirectory(workingDirectory):
9292
logger.info('changing to working directory %s', workingDirectory)
9393
os.chdir(workingDirectory)
9494

95-
def getFastToc(self, runner, device):
95+
@staticmethod
96+
def getFastToc(runner, device):
9697
"""
9798
Retrieve the normal TOC table from the drive.
9899
@@ -507,7 +508,8 @@ def getHTOA(self):
507508
stop = track.getIndex(1).absolute - 1
508509
return start, stop
509510

510-
def getCoverArt(self, path, release_id):
511+
@staticmethod
512+
def getCoverArt(path, release_id):
511513
"""
512514
Get cover art image from Cover Art Archive.
513515

whipper/test/test_result_logger.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,16 @@ def __init__(self):
3030
MockImageTrack(2, 16264, 33487)
3131
]
3232

33-
def getCDDBDiscId(self):
33+
@staticmethod
34+
def getCDDBDiscId():
3435
return "c30bde0d"
3536

36-
def getMusicBrainzDiscId(self):
37+
@staticmethod
38+
def getMusicBrainzDiscId():
3739
return "eyjySLXGdKigAjY3_C0nbBmNUHc-"
3840

39-
def getMusicBrainzSubmitURL(self):
41+
@staticmethod
42+
def getMusicBrainzSubmitURL():
4043
return (
4144
"https://musicbrainz.org/cdtoc/attach?toc=1+13+228039+150+16414+"
4245
"33638+51378+69369+88891+104871+121645+138672+160748+178096+194680"

0 commit comments

Comments
 (0)