ci(github): PHP 7.2 is the minimal requirement

Signed-off-by: Thierry Bugier <tbugier@teclib.com>

Author: btry

.github/workflows/tests.yml

@@ -23,7 +23,7 @@ jobs:
  runs-on: "ubuntu-latest"
  strategy:
  matrix:
- php-versions: [7.4]
+ php-versions: [7.2]
  env:
           - { GLPI_BRANCH: 9.5/bugfixes, SKIP_FUNCTIONAL_TESTS: false }
  services:

inc/field/emailfield.class.php

@@ -38,7 +38,7 @@
 
 class EmailField extends TextField
 {
- public function getDesignSpecializationField()
+ public function getDesignSpecializationField(): array
    {
  $rand = mt_rand();
 
@@ -72,7 +72,7 @@ public function getDesignSpecializationField()
       ];
    }
 
- public function getRenderedHtml($canEdit = true)
+ public function getRenderedHtml($canEdit = true): string
    {
  if (!$canEdit) {
  return $this->value;
@@ -140,7 +140,7 @@ public function hasInput($input): bool
  return isset($input['formcreator_field_' . $this->question->getID()]);
    }
 
- public function parseAnswerValues($input, $nonDestructive = false)
+ public function parseAnswerValues($input, $nonDestructive = false): bool
    {
  $key = 'formcreator_field_' . $this->question->getID();
  if (!isset($input[$key])) {
@@ -188,7 +188,7 @@ public function isAnonymousFormCompatible(): bool
  return true;
    }
 
- public function getHtmlIcon()
+ public function getHtmlIcon(): string
    {
  return '<i class="fa fa-envelope" aria-hidden="true"></i>';
    }

inc/field/ldapselectfield.class.php

@@ -185,7 +185,7 @@ public function serializeValue(): string
  return $this->value;
    }
 
- public function deserializeValue($value): string
+ public function deserializeValue($value)
    {
  $this->value = $value;
    }
@@ -311,7 +311,7 @@ public function isAnonymousFormCompatible(): bool
  return false;
    }
 
- public function getHtmlIcon():string
+ public function getHtmlIcon(): string
    {
  return '<i class="fa fa-sitemap" aria-hidden="true"></i>';
    }

inc/field/textareafield.class.php

@@ -196,12 +196,12 @@ public function prepareQuestionInputForSave($input): array
  return $input;
    }
 
- public function hasInput($input) : bool
+ public function hasInput($input): bool
    {
  return isset($input['formcreator_field_' . $this->question->getID()]);
    }
 
- public function parseAnswerValues($input, $nonDestructive = false)
+ public function parseAnswerValues($input, $nonDestructive = false): bool
    {
  parent::parseAnswerValues($input, $nonDestructive);
  $key = 'formcreator_field_' . $this->question->getID();
@@ -244,7 +244,7 @@ public function lessThan($value): bool
  return !$this->greaterThan($value) && !$this->equals($value);
    }
 
- public function isAnonymousFormCompatible()
+ public function isAnonymousFormCompatible(): bool
    {
  return true;
    }

inc/field/textfield.class.php

@@ -127,7 +127,7 @@ public function deserializeValue($value)
          : '';
    }
 
- public function getValueForDesign()
+ public function getValueForDesign(): string
    {
  if ($this->value === null) {
  return '';
@@ -198,7 +198,7 @@ public function isValidValue($value): bool
  return true;
    }
 
- public static function getName()
+ public static function getName(): string
    {
  return __('Text', 'formcreator');
    }