Fix gRPC Retry Mechanism for Unsuccessful HTTP Responses - #6829
Merged
Conversation
JiwonKKang
force-pushed
the
grpc-retry
branch
from
October 28, 2024 17:17
18637d9 to
b7a944c
Compare
JiwonKKang
force-pushed
the
grpc-retry
branch
from
October 28, 2024 17:28
b7a944c to
7af74ac
Compare
jack-berg
approved these changes
Oct 28, 2024
jack-berg
left a comment
Member
There was a problem hiding this comment.
Just a minor comment about class / method visibility level in the test, but looks good. Thanks!
| import org.junit.jupiter.params.ParameterizedTest; | ||
| import org.junit.jupiter.params.provider.MethodSource; | ||
|
|
||
| public class OkHttpGrpcSenderTest { |
Member
There was a problem hiding this comment.
#nit: we omit public on test classes and test methods in this repo, since junit 5 doesn't require them to be public
Suggested change
| public class OkHttpGrpcSenderTest { | |
| class OkHttpGrpcSenderTest { |
Contributor
Author
There was a problem hiding this comment.
Thanks for the code review😊
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Impact:
This fix ensures that gRPC requests are retried according to policy when encountering transient 503 errors, enhancing resilience in case of temporary unavailability.