Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upHosting the Health Check routes in an existing Akka HTTP server #599
Comments
|
It looks to me like @sdeigm could you try that and report back? @akka/akka-team, should that be the documented approach? |
|
There is one difference though and that is that it potentially adds modifying routes, join cluster, down node etc. While health check alone would perhaps be less dangerous. |
|
Good point. It would definitely be useful to be able to get hold of the health check routes on their own. My interpretation of the original post was that @sdeigm wanted both anyway, but maybe not. |
I just tried it out and it works. A /alive and a /ready route are added to my server. Thanks for the tip! And yes you are correct @TimMoore, in my case I want the routes to modify the cluster membership anyway. So for me personally, this solves the issue, but for others that might be a problem. |
|
Thanks for confirming @sdeigm ... this should at least be documented somewhere, IMHO, so maybe we can leave the issue open for that? |
|
A request to allow embedding only the health check routes in an existing server is in #605. |
Leaving open for improving the docs |
Hosting the Akka HTTP managment routes in an existing HTTP server currently only provides access to the routes dealing with the the cluster membership and status, not the Health Check routes.
It would be good to also include the Health Check routes (readiness and liveness) into this interface so that they can be reached at the same port address as the other routes. This avoids the opening of another HTTP server port for just that reason.