Skip to content

/ zrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed color tool bug #419

Open
wants to merge 3 commits into
base: master
from
Open

fixed color tool bug #419

wants to merge 3 commits into from

Conversation

@troy351
Copy link

@troy351 troy351 commented Jan 17, 2019 •
edited

I assume it's a typo
troy351 added 2 commits Jan 17, 2019
@troy351
fixed color tool bug
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
9bbbffa
@troy351
lerp undefined fixed
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
955de18
@Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Jan 30, 2019

Thanks for your contribution!
Can you describe what problem this bug cause?
@troy351
Copy link
Author

@troy351 troy351 commented Jan 30, 2019

It's just a typo here since color is a string and color[i] < 0 means nothing. should use colorArr[i] < 0 instead.
As for the if (!leftColor || !rightColor) return; part, just do the Can not read property xxx of null check
@Ovilia
Ovilia approved these changes Jan 31, 2019
View changes
Copy link
Contributor

@Ovilia Ovilia left a comment •
edited

LGTM.

@100pah Please have a look and have it merged if it's OK.
@troy351
Merge pull request #1 from ecomfe/master
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
f52b54e 
update to lastest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ovilia Ovilia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@troy351 @Ovilia
You can’t perform that action at this time.