Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Logout and OIDC Metadata #145

Open
flyboarder opened this issue Oct 23, 2019 · 1 comment
Open

Support Logout and OIDC Metadata #145

flyboarder opened this issue Oct 23, 2019 · 1 comment

Comments

@flyboarder
Copy link

@flyboarder flyboarder commented Oct 23, 2019

Grant js should allow us to logout of the OAuth provider by forwarding a request to the OAuth providers logout url.

Also OIDC providers should have a metadata endpoint:
https://docs.microsoft.com/en-us/azure/active-directory/develop/v1-protocols-openid-connect-code#openid-connect-metadata-document

Similarly to grant-profile we should be able to fetch the correct url using the metadata and a map of logout urls to providers.

@simov
Copy link
Owner

@simov simov commented Oct 23, 2019

Thanks for the feedback @flyboarder!

Grant is not an OpenID Connect Certified client (yes there is such thing), so it doesn't claim to support the whole spec. Grant is more like OAuth transport layer then a fully compliant OIDC client or anything else.

That's the reason why grant-profile is outside of it, because it falls out of scope. Similarly I have an experimental grant-oidc module that is supposed to be the place for OIDC related stuff. Well, the initial goal would be to just get the public keys from the above mentioned metadata endpoint and properly validate the id_token.

As for logout URLs and other related OIDC goodies, that's a great idea! It just won't be in this module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.