Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Enable building with dotnetcli for non-Windows #692
Conversation
|
You should add a new task in The new task should probably be invoked from And I would much rather see changes to |
|
@lzybkr I'm fine having a single csproj, but wasn't sure if you preferred keeping the existing project as-is. |
|
Does building against PowerShell Standard work against Windows PowerShell 5.1 on Win7 and Win10 without shipping type forwarding dlls? If so, they fine, but I'm guessing there isn't a clean solution to that problem yet. A single csproj can build multiple ways with conditions though - and that's what I was suggesting. |
|
@lzybkr If Win7 doesn't have .Net 4.7, the shims are needed. Newer Win10 has 4.7.x. We plan to have a module that contains the .Net Std shims that other modules can reference. |
|
@lzybkr are you ok if we move both the Windows and non-Windows build to dotnetcli? Would simplify things quite a bit. |
|
@SteveL-MSFT - if you submit a PR so I can see how it's simpler, that would help. I don't want to distribute unnecessary private copies of dlls, I'm already unhappy about needing I also don't want runtime logic that might affect startup time, e.g. path searching for type forwarders dlls. |
|
I'm going to have to put this on hold for now. Got it building and tests running with dotnetcli, but tests fail to run correctly. |
|
Tests pass on macOS and Windows w/ PSCore6. Out of town next few days. Will get it working in WinPS after I get back |
SteveL-MSFT
force-pushed the
SteveL-MSFT:build-unix
branch
5 times, most recently
from
5223311
to
71fc314
|
@lzybkr I think this is ready for review |
|
I think you should add instructions for building to You also need to try running the tests from VS. You did not update the |
added Clipboard capability for non-Windows
|
@lzybkr verified solution builds and tests run in VS2017 |
|
I think this is almost ready, but I noticed the module version is set to |
|
@lzybkr the .psd1 file wasn't changed in this PR and looking in my repo, it's still set to 2.0.0 |
Ported csproj to use dotnetcli. When run from PSCore6, builds for netcoreapp21. When run from Windows PowerShell 5.1, builds for net461. Tests ran on Windows PowerShell, PSCore6 Windows, PSCore6 Ubuntu 18.04, and PSCore6 macOS all passing. Linux run requires xclip to be installed as that is necessary for clipboard to function (which tests depend upon). Using dotnetsdk 2.1. Appropriate .Net Framework 4.6.1 SDK is required for Windows PowerShell build.
Fix #652