Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[Training/Python] Add option to enable symbolic shape inference #5107
+99
−57
Conversation
…save model to directory
KeDengMS
requested review from
BowenBao,
liqunfu,
spandantiwari,
thiagocrepaldi and
microsoft/onnxruntime
as
code owners
| @@ -198,23 +202,16 @@ def _preprocess(self, in_mp): | |||
|
|
|||
| # returns True if no more ready nodes | |||
| def _insert_ready_nodes(): | |||
| ready_nodes = [pn for pn in pending_nodes if all([i in defined for i in pn.input if i])] | |||
| ready_nodes = [pn for pn in pending_nodes if len(pn.input) == 0 or all([i in defined for i in pn.input if i])] | |||
This comment has been minimized.
This comment has been minimized.
RandySheriffH
Sep 11, 2020
•
Contributor
len(pn.input) == 0 [](start = 57, length = 19)
nit:
if not pn.input #Resolved
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
KeDengMS commentedSep 10, 2020
and allow save model to directory
Description: Describe your changes.
Motivation and Context