Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make metric queries include current date #171

Open
1 task
Auz opened this issue Nov 27, 2021 · 0 comments
Open
1 task

Make metric queries include current date #171

Auz opened this issue Nov 27, 2021 · 0 comments
Labels
good first issue

Comments

@Auz
Copy link
Contributor

@Auz Auz commented Nov 27, 2021 •
edited by jdorn

When we show data for a metric, we currently don't include the current day's worth of data. For users just getting set up, they may only have events from today, and want to test out if the query is working, and by excluding events from 'today', they can't see results.

TODO:

  • In packages/back-end/src/services/experiments.ts on line 329, instead of using the current date as the value of to, use tomorrow instead (add 1 day).
@jdorn jdorn changed the title Consider changing the current date limit in metric queries do not include today Make metric queries include current date Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@Auz @jdorn