fix: allow Unicode characters in description fields #7761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes coollabsio#6904 The DESCRIPTION_PATTERN regex was too restrictive, only allowing ASCII letters (a-zA-Z) and numbers (0-9). This prevented users from writing descriptions in non-English languages like Japanese, Turkish, Chinese, etc. Changes: - Updated regex to use Unicode character classes: \p{L} for letters and \p{N} for numbers - Added 'u' (Unicode) modifier to the regex pattern - Updated error message to reflect that Unicode characters are allowed This allows users to write descriptions in their native languages while still maintaining security by restricting dangerous special characters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6904
The
DESCRIPTION_PATTERNregex was too restrictive, only allowing ASCII letters (a-zA-Z) and numbers (0-9). This prevented users from writing descriptions in non-English languages like Japanese, Turkish, Chinese, etc.Changes
\p{L}for letters and\p{N}for numbersu(Unicode) modifier to the regex patternBefore
'/^[a-zA-Z0-9\s\-_.:\/()\'\",.!?@#%&+=[\]{}|~`*]+$/'After
'/^[\p{L}\p{N}\s\-_.:\/()\'\",.!?@#%&+=[\]{}|~`*]+$/u'Testing
Users can now write descriptions in their native languages (Japanese: こんにちは, Turkish: Türkçe, Chinese: 中文) while still maintaining security by restricting dangerous special characters.