This repository was archived by the owner on May 8, 2026. It is now read-only.
fix: adding deprecated tags to deprecated methods - #472
Merged
Conversation
Adding delivery attempt count to PubsubMessages as a message attribute, and creating helper function to allow users to get the count without knowing implementation details.
lettering is not enabled
Codecov Report
@@ Coverage Diff @@
## master #472 +/- ##
============================================
- Coverage 79.17% 79.14% -0.04%
Complexity 323 323
============================================
Files 21 21
Lines 2925 2925
Branches 166 166
============================================
- Hits 2316 2315 -1
Misses 541 541
- Partials 68 69 +1
Continue to review full report at Codecov.
|
stephaniewang526
requested review from
chingor13
and removed request for
stephaniewang526
January 21, 2021 18:47
elharo
approved these changes
Jan 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #249 ☕️