Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

fix: update MessageDispatcher to not extend deadlines of messages which arrive early to 60s - #570

Merged
hannahrogers-google merged 3 commits into
masterfrom
dpcollins-google-patch-1
Mar 16, 2021
Merged

fix: update MessageDispatcher to not extend deadlines of messages which arrive early to 60s#570
hannahrogers-google merged 3 commits into
masterfrom
dpcollins-google-patch-1

Conversation

@dpcollins-google

@dpcollins-google dpcollins-google commented Mar 15, 2021

Copy link
Copy Markdown
Contributor

It looks like we had 60 second deadline extensions in the client before we attempt to update this property, on the premise that it would be updated inline. Due to code drift, this is no longer true, so I changed it to 10s (the min value) by default instead for messages which arrive before the first recalculation cycle.

@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 15, 2021
@product-auto-label product-auto-label Bot added the api: pubsub Issues related to the googleapis/java-pubsub API. label Mar 15, 2021
@dpcollins-google dpcollins-google changed the title Update MessageDispatcher to not extend deadlines of messages which arrive early to 60s fix: update MessageDispatcher to not extend deadlines of messages which arrive early to 60s Mar 15, 2021
@codecov

codecov Bot commented Mar 15, 2021

Copy link
Copy Markdown

Codecov Report

Merging #570 (3bb0679) into master (21886d3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #570   +/-   ##
=========================================
  Coverage     78.83%   78.83%           
  Complexity      379      379           
=========================================
  Files            27       27           
  Lines          3420     3420           
  Branches        171      171           
=========================================
  Hits           2696     2696           
  Misses          651      651           
  Partials         73       73           
Impacted Files Coverage Δ Complexity Δ
.../com/google/cloud/pubsub/v1/MessageDispatcher.java 84.87% <100.00%> (ø) 26.00 <0.00> (ø)
...in/java/com/google/cloud/pubsub/v1/Subscriber.java 80.71% <100.00%> (ø) 24.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6e299f...3bb0679. Read the comment docs.

@hannahrogers-google
hannahrogers-google merged commit e174e20 into master Mar 16, 2021
@hannahrogers-google
hannahrogers-google deleted the dpcollins-google-patch-1 branch March 16, 2021 01:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: pubsub Issues related to the googleapis/java-pubsub API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants