Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

fix: ordering keys publishing of last batch - #9

Merged
kamalaboulhosn merged 3 commits into
googleapis:masterfrom
kamalaboulhosn:master
Nov 26, 2019
Merged

fix: ordering keys publishing of last batch#9
kamalaboulhosn merged 3 commits into
googleapis:masterfrom
kamalaboulhosn:master

Conversation

@kamalaboulhosn

Copy link
Copy Markdown
Contributor

Ensure that the last batch for an ordering key gets published.

…e currently outstanding message has finished publishing with an ordering key that the last batch does in fact get published.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 25, 2019
@kamalaboulhosn kamalaboulhosn changed the title Fix ordering keys publishing of last batch fix: Ordering keys publishing of last batch Nov 25, 2019
@kamalaboulhosn kamalaboulhosn changed the title fix: Ordering keys publishing of last batch fix: ordering keys publishing of last batch Nov 25, 2019
@codecov

codecov Bot commented Nov 25, 2019

Copy link
Copy Markdown

Codecov Report

Merging #9 into master will increase coverage by 0.04%.
The diff coverage is 81.81%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master      #9      +/-   ##
===========================================
+ Coverage     78.76%   78.8%   +0.04%     
- Complexity      285     288       +3     
===========================================
  Files            21      21              
  Lines          2566    2576      +10     
  Branches        125     128       +3     
===========================================
+ Hits           2021    2030       +9     
  Misses          490     490              
- Partials         55      56       +1
Impacted Files Coverage Δ Complexity Δ
...gle/cloud/pubsub/v1/SequentialExecutorService.java 90.8% <100%> (ø) 0 <0> (ø) ⬇️
...ain/java/com/google/cloud/pubsub/v1/Publisher.java 89.07% <80%> (+0.03%) 43 <2> (+3) ⬆️
...ava/com/google/cloud/pubsub/v1/OpenCensusUtil.java 71.66% <0%> (ø) 5% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53c4030...43878d0. Read the comment docs.

@kamalaboulhosn kamalaboulhosn added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 25, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 25, 2019
@kamalaboulhosn
kamalaboulhosn merged commit 02c3771 into googleapis:master Nov 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants