fix: Two QOL issues with PubsubLiteIO - #552
Merged
Merged
Conversation
- UUIDs generated randomly are not valid UTF-8 strings so they cannot be read from the CPS shim by default - Restrictions on bundle closing make it hard to test PSL with windowing pipelines
Codecov Report
@@ Coverage Diff @@
## master #552 +/- ##
============================================
- Coverage 72.70% 72.60% -0.10%
Complexity 860 860
============================================
Files 156 156
Lines 4477 4483 +6
Branches 210 209 -1
============================================
Hits 3255 3255
- Misses 1102 1107 +5
- Partials 120 121 +1
Continue to review full report at Codecov.
|
- UUIDs generated randomly are not valid UTF-8 strings so they cannot be read from the CPS shim by default - Restrictions on bundle closing make it hard to test PSL with windowing pipelines
manuelmenzella-google
approved these changes
Mar 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #542 ☕️