fix: Blob.downloadTo() methods do not wrap RetryHelper$RetryHelperException - #218
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #218 +/- ##
============================================
+ Coverage 63.50% 63.67% +0.17%
- Complexity 540 548 +8
============================================
Files 30 31 +1
Lines 4759 4785 +26
Branches 427 428 +1
============================================
+ Hits 3022 3047 +25
- Misses 1577 1578 +1
Partials 160 160
Continue to review full report at Codecov.
|
elharo
reviewed
Apr 1, 2020
| assertArrayEquals(expected, actual); | ||
| } | ||
|
|
||
| @Test |
Contributor
There was a problem hiding this comment.
Per Google practices, new tests should use Mockito, not EasyMock. Yes, even if this means some tests use Mockito and others use EasyMock.
Contributor
Author
There was a problem hiding this comment.
Is this rule applied to the tests within a single file or withing a package?
Is it possible to make an exception?
Contributor
|
I think we will need to make an exception for now but may be good to file
an issue to track it as future work.
…On Wed, Apr 1, 2020, 11:57 PM Dmitry ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
google-cloud-storage/src/test/java/com/google/cloud/storage/BlobTest.java
<#218 (comment)>
:
> @@ -662,4 +661,25 @@ public Long answer() throws Throwable {
byte actual[] = Files.readAllBytes(file.toPath());
assertArrayEquals(expected, actual);
}
+
+ @test
Is this rule applied to the tests within a single file or withing a
package?
Is it possible to make an exception?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#218 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAORXQB5KYTBLUVFXI4DNWDRKQZMBANCNFSM4LXMU2UQ>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #100