Skip to content

Add materialName parameter to OBJExport.MTL#18686

Open
FrankNesling wants to merge 2 commits into
BabylonJS:masterfrom
FrankNesling:enhancement/obj-export-mtl-material-name
Open

Add materialName parameter to OBJExport.MTL#18686
FrankNesling wants to merge 2 commits into
BabylonJS:masterfrom
FrankNesling:enhancement/obj-export-mtl-material-name

Conversation

@FrankNesling

Copy link
Copy Markdown

MTL Export does not hardcode "mat1" anymore.
That way multiple materials (via one .mtl that concats all MTL-outputs) can be exported alongside the OBJ without a hacky post-processing.

@RaananW RaananW left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread packages/dev/serializers/src/OBJ/objSerializer.ts
@RaananW

RaananW commented Jul 13, 2026

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@bjsplat

bjsplat commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat

bjsplat commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Snapshot stored with reference name:
refs/pull/18686/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/18686/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/18686/merge/index.html#WGZLGJ#4600

Links to test your changes to core in the published versions of the Babylon tools (does not contain changes you made to the tools themselves):

https://playground.babylonjs.com/?snapshot=refs/pull/18686/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/18686/merge
https://gui.babylonjs.com/?snapshot=refs/pull/18686/merge
https://nme.babylonjs.com/?snapshot=refs/pull/18686/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/18686/merge#BCU1XR#0

If you made changes to the sandbox or playground in this PR, additional comments will be generated soon containing links to the dev versions of those tools.

@bjsplat

bjsplat commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

âš¡ Performance Test Results

🟢 All performance tests passed — no regressions detected.

@bjsplat

bjsplat commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

@bjsplat

bjsplat commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

@bjsplat

bjsplat commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

@bjsplat

bjsplat commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

🟢 Memory Leak Test Results

4 passed, 0 leaked out of 4 scenarios

🟢 All memory leak tests passed — no leaks detected.

Passed Scenarios (4)
Scenario Package
Core Playground #2FDQT5#1508 @babylonjs/core
Core Playground #T90MQ4#14 @babylonjs/core
Core Playground #8EDB5N#2 @babylonjs/core
Core Playground #LL5BIQ#636 @babylonjs/core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants