boot-qemu: Always use -no-reboot#65
Conversation
To make things easier for shutting down after a reboot (or a reboot on panic), always use -no-reboot regardless of architecture. Signed-off-by: Kees Cook <keescook@chromium.org>
msfjarvis
left a comment
There was a problem hiding this comment.
This looks reasonable from what I've read about -no-reboot and -no-shutdown but I'll let someone who uses this on the daily merge the PR.
|
Hmmm, we might want to rethink doing this unconditionally, as I think it will cause us to miss out on timeouts for certain crashes. |
|
But why didn't the running notice it never reached userspace? |
Because QEMU exited cleanly, which seems expected to me in that case with |
|
What about matching the log against some string that you print within QEMU at the end of the run (and checking it is there only once)? Poor man's solution, but it may be a good idea and can be done in addition to another approach too. We did something like that for tests etc. |
Thanks for the suggestion, I have gone ahead and filed #96 to further discuss that. |
To make things easier for shutting down after a reboot (or a reboot on
panic), always use -no-reboot regardless of architecture.
Signed-off-by: Kees Cook keescook@chromium.org