Made the game responsive#34
Merged
Merged
Conversation
Contributor
Author
|
Can you review this @dev-lovedeep |
dev-lovedeep
approved these changes
Oct 31, 2022
Contributor
dev-lovedeep
left a comment
There was a problem hiding this comment.
make this small change, and then we can merge
Comment on lines
+17
to
+18
| if (level !== '1' && level !== '2' && level !== '3') | ||
| level = '1'; // Setting default level to 1 |
Comment on lines
+2
to
+3
| if (screen.availHeight > screen.availWidth) | ||
| alert("Please switch to landscape mode for a better experience!"); |
Contributor
There was a problem hiding this comment.
this will check only one, instead add an event listener
landscape orientation (Hmmm I wonder any other awesome website developed by awesome people which only allow us to play the game if the screen is a particular size)
Contributor
Author
|
Adding a event listener for resize and putting alerts in it, made the game very buggy. |
| display: flex; | ||
| justify-content: center; | ||
| align-items: center; | ||
| font-size: 8rem; |
Contributor
There was a problem hiding this comment.
this is way too big change it to something like 2 or 3rem
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29