Skip to content

feat: update sample to use beam-side lite io - #5312

Merged
anguillanneuf merged 8 commits into
masterfrom
pubsublite
Sep 14, 2021
Merged

feat: update sample to use beam-side lite io#5312
anguillanneuf merged 8 commits into
masterfrom
pubsublite

Conversation

@anguillanneuf

@anguillanneuf anguillanneuf commented May 26, 2021

Copy link
Copy Markdown
Member

Pub/Sub Lite maintains two I/O connectors to Beam.

This PR updates the original sample to use the Beam-side PubsubLiteIO.

Wait to merge this PR after getting approvals from the Pub/Sub Lite team.


Chatted with @manuelmenzella-google, let's wait to merge it after the Beam-side I/O is stable.

@anguillanneuf
anguillanneuf requested a review from a team May 26, 2021 18:34
@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label May 26, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label May 26, 2021
@anguillanneuf anguillanneuf added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels May 26, 2021
@anguillanneuf

anguillanneuf commented May 26, 2021

Copy link
Copy Markdown
Member Author

Is it possible to add https://github.com/orgs/googleapis/teams/api-pubsublite as a reviewer here?

@anguillanneuf anguillanneuf added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 27, 2021
@lesv

lesv commented Jun 7, 2021

Copy link
Copy Markdown
Contributor

@api-pubsublite PLEASE REVEIW

@lesv

lesv commented Jun 7, 2021

Copy link
Copy Markdown
Contributor

@anguillanneuf I can't invite teams from another org, we can try to create a replicate team in this org, however. Could you invite an individual to review this? If you can't add them directly, you can mention them in a comment.

@anguillanneuf

anguillanneuf commented Jun 7, 2021

Copy link
Copy Markdown
Member Author

@lesv A replicate team for https://github.com/orgs/googleapis/teams/api-pubsublite is the best.

I chatted with @manuelmenzella-google, we decided to punt on it until the I/O connector released with Beam is stable, which could be another month or two.


Update: Once https://github.com/orgs/googlecloudplatform/teams/api-pubsub-and-pubsublite is ready. We can add it as a reviewer.

@lesv

lesv commented Jun 9, 2021

Copy link
Copy Markdown
Contributor

@anguillanneuf Looks like there needs to be some manual work at this point.

@lesv
lesv requested a review from a team June 9, 2021 03:15
@averikitsch averikitsch removed their assignment Jun 11, 2021
@eaball35
eaball35 requested a review from a team as a code owner June 15, 2021 19:55
@lesv lesv added api: pubsublite Issues related to the Pub/Sub Lite API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Jul 14, 2021
@lesv

lesv commented Aug 27, 2021

Copy link
Copy Markdown
Contributor

@anguillanneuf What's the plan for this? Will it ever be merged or should we close it?

@anguillanneuf anguillanneuf removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 14, 2021
@snippet-bot

snippet-bot Bot commented Sep 14, 2021

Copy link
Copy Markdown

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsublite Issues related to the Pub/Sub Lite API. cla: yes This human has signed the Contributor License Agreement. priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants