Skip to content

Mention that newer Log4j2 versions do not need additional fields #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aabmass merged 1 commit into from
Oct 7, 2024
Merged

Mention that newer Log4j2 versions do not need additional fields #379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion examples/instrumentation-quickstart/src/main/resources/log4j2.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,10 @@
https://logging.apache.org/log4j/2.x/manual/json-template-layout.html#event-templates -->
<JsonTemplateLayout eventTemplateUri="classpath:GcpLayout.json">
<!-- Extend the included GcpLayout to include the trace and span IDs from Mapped
Diagnostic Context (MDC) so that Cloud Logging can correlate Logs and Spans -->
Diagnostic Context (MDC) so that Cloud Logging can correlate Logs and Spans

Since log4j2 2.24.0, GcpLayout.json already includes trace context logging from MDC and
the below additional fields are no longer needed -->
<EventTemplateAdditionalField
key="logging.googleapis.com/trace"
format="JSON"
Expand Down