Integrating Next-Auth to do user authentication on the website#10
Merged
Conversation
…authenticated user can fetch prompts from the real backend using an API middlelayer
…th the labeler backend.
yk
approved these changes
Dec 15, 2022
Collaborator
yk
left a comment
There was a problem hiding this comment.
lgtm
suggestion for improvement: use nextjs runtime configuration (https://nextjs.org/docs/api-reference/next.config.js/runtime-configuration)
the reason is: process.env is grabbed at build-time in many places, so we'd have to include secrets into the docker build, which is suboptimal. with runtime configuration, we can supply environment variables at runtime
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the website to provide two forms of user authentication (Discord & Email) and then proxies data requests to the FastAPI backend while keeping the client api key secure. This also registered newly signed up users to the labeler backend.
The UI is still pretty ugly and not useful in any way.