feat: Add a more descriptive test failure message to NoticeFieldsTest.#1369
feat: Add a more descriptive test failure message to NoticeFieldsTest.#1369bdferris-v2 merged 2 commits intomasterfrom
Conversation
|
✅ Rule acceptance tests passed. |
|
✅ Rule acceptance tests passed. |
* chore: fix deprecated dependency * chore: auto-format * feat: handle missing RULES.md * feat: refactor upload process and handle more errors * Add a more descriptive test failure message to NoticeFieldsTest. (#1369) * Docs: Update notice migration file (#1357) * refactor migration file * update documentation with new file * fix wording * Make easier to read * remove colors --------- Co-authored-by: Emma Blue <90632321+emmambd@users.noreply.github.com> * feat: Fail acceptance tests on significant change in warnings (#1377) * Refactor logic out of of outputcomparator/cli/Main and into a new ValidationReportComparator class for easier testing. In addition, update ValidationReportComparator to trigger a comparison error if changed warnings are above configured thresholds. * Additional unit tests for ValidationReportComparator. --------- Co-authored-by: Ryon Coleman <ryon55@gmail.com> Co-authored-by: Brian Ferris <bdferris+v2@google.com> Co-authored-by: isabelle-dr <isabelle@mobilitydata.org> Co-authored-by: Emma Blue <90632321+emmambd@users.noreply.github.com> Co-authored-by: David Gamez <1192523+davidgamez@users.noreply.github.com>
…1384) * chore: fix deprecated dependency * chore: auto-format * feat: handle missing RULES.md * feat: refactor upload process and handle more errors * Add a more descriptive test failure message to NoticeFieldsTest. (#1369) * Docs: Update notice migration file (#1357) * refactor migration file * update documentation with new file * fix wording * Make easier to read * remove colors --------- Co-authored-by: Emma Blue <90632321+emmambd@users.noreply.github.com> * feat: Fail acceptance tests on significant change in warnings (#1377) * Refactor logic out of of outputcomparator/cli/Main and into a new ValidationReportComparator class for easier testing. In addition, update ValidationReportComparator to trigger a comparison error if changed warnings are above configured thresholds. * Additional unit tests for ValidationReportComparator. * Add sentry script to static html header * Add sentry script to web service * Remove sentry properties from source control --------- Co-authored-by: Ryon Coleman <ryon55@gmail.com> Co-authored-by: Brian Ferris <bdferris+v2@google.com> Co-authored-by: isabelle-dr <isabelle@mobilitydata.org> Co-authored-by: Emma Blue <90632321+emmambd@users.noreply.github.com>
* chore: fix deprecated dependency * chore: auto-format * feat: handle missing RULES.md * feat: refactor upload process and handle more errors * Add a more descriptive test failure message to NoticeFieldsTest. (MobilityData#1369) * Docs: Update notice migration file (MobilityData#1357) * refactor migration file * update documentation with new file * fix wording * Make easier to read * remove colors --------- Co-authored-by: Emma Blue <90632321+emmambd@users.noreply.github.com> * feat: Fail acceptance tests on significant change in warnings (MobilityData#1377) * Refactor logic out of of outputcomparator/cli/Main and into a new ValidationReportComparator class for easier testing. In addition, update ValidationReportComparator to trigger a comparison error if changed warnings are above configured thresholds. * Additional unit tests for ValidationReportComparator. --------- Co-authored-by: Ryon Coleman <ryon55@gmail.com> Co-authored-by: Brian Ferris <bdferris+v2@google.com> Co-authored-by: isabelle-dr <isabelle@mobilitydata.org> Co-authored-by: Emma Blue <90632321+emmambd@users.noreply.github.com> Co-authored-by: David Gamez <1192523+davidgamez@users.noreply.github.com>
…obilityData#1384) * chore: fix deprecated dependency * chore: auto-format * feat: handle missing RULES.md * feat: refactor upload process and handle more errors * Add a more descriptive test failure message to NoticeFieldsTest. (MobilityData#1369) * Docs: Update notice migration file (MobilityData#1357) * refactor migration file * update documentation with new file * fix wording * Make easier to read * remove colors --------- Co-authored-by: Emma Blue <90632321+emmambd@users.noreply.github.com> * feat: Fail acceptance tests on significant change in warnings (MobilityData#1377) * Refactor logic out of of outputcomparator/cli/Main and into a new ValidationReportComparator class for easier testing. In addition, update ValidationReportComparator to trigger a comparison error if changed warnings are above configured thresholds. * Additional unit tests for ValidationReportComparator. * Add sentry script to static html header * Add sentry script to web service * Remove sentry properties from source control --------- Co-authored-by: Ryon Coleman <ryon55@gmail.com> Co-authored-by: Brian Ferris <bdferris+v2@google.com> Co-authored-by: isabelle-dr <isabelle@mobilitydata.org> Co-authored-by: Emma Blue <90632321+emmambd@users.noreply.github.com>
* chore: fix deprecated dependency * chore: auto-format * feat: handle missing RULES.md * feat: refactor upload process and handle more errors * Add a more descriptive test failure message to NoticeFieldsTest. (#1369) * Docs: Update notice migration file (#1357) * refactor migration file * update documentation with new file * fix wording * Make easier to read * remove colors --------- Co-authored-by: Emma Blue <90632321+emmambd@users.noreply.github.com> * feat: Fail acceptance tests on significant change in warnings (#1377) * Refactor logic out of of outputcomparator/cli/Main and into a new ValidationReportComparator class for easier testing. In addition, update ValidationReportComparator to trigger a comparison error if changed warnings are above configured thresholds. * Additional unit tests for ValidationReportComparator. * Add sentry script to static html header * Add sentry script to web service * Remove sentry properties from source control * feat: add newrelic agent to web service --------- Co-authored-by: Ryon Coleman <ryon55@gmail.com> Co-authored-by: Brian Ferris <bdferris+v2@google.com> Co-authored-by: isabelle-dr <isabelle@mobilitydata.org> Co-authored-by: Emma Blue <90632321+emmambd@users.noreply.github.com>
Summary:
To make it easier to understand what this test failure means, I've added a more descriptive failure message. The failure now looks like:
gradle testto make sure you didn't break anything