Fix BlockBreakEvent misfire in Adventure mode (#14042)#14044
Open
JavierFlores09 wants to merge 2 commits into
Open
Fix BlockBreakEvent misfire in Adventure mode (#14042)#14044JavierFlores09 wants to merge 2 commits into
JavierFlores09 wants to merge 2 commits into
Conversation
ee6890c to
c280fd5
Compare
Move the blockActionRestricted check to be made before the event itself is called.
c280fd5 to
bda6e81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the blockActionRestricted check to be made before the event itself is called.
BBE-misfire-fixed.mp4
as you can see in the video, no BBE is called unless I switch back to the correct item (I think that's just a side effect of lag compensation)