[AMR][Godunov] enable grid refinement by tdavidcl · Pull Request #632 · Shamrock-code/Shamrock

tdavidcl · 2024-10-06T21:00:06Z

AMR refinement

This PR add AMR grid refinement to shamrock. Currently only a cell mass based one is implemented, but more are to come ...

Possible regressions

Most of the solver is unchanged, only the block graph to cell graph lowering algorithm had to be changed because of issues ... Maybe this change performance but its mandatory for now ...

github-actions · 2024-10-11T14:53:37Z

Pre-commit check: ✅

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check yaml...............................................................Passed
detect private key.......................................................Passed
Validate GitHub Workflows................................................Passed
clang-format.............................................................Passed
Check doxygen headers....................................................Passed
Check license headers....................................................Passed
Check #pragma once.......................................................Passed
Check SYCL #include......................................................Passed

Test pipeline can run.

github-actions · 2024-10-11T15:44:56Z

Doxygen diff with `main`

Removed warnings : 52
New warnings : 98
Warnings count : 5511 → 5557 (0.8%)

Detailed changes :

- src/shammodels/amr/AMRBlock.hpp:108: warning: Member utils_get_cell_coords(std::pair< TgridVec, TgridVec > input, u32 lid) (function) of struct shammodels::amr::AMRBlock is not documented.
+ src/shammodels/amr/AMRBlock.hpp:109: warning: Member utils_get_cell_coords(std::pair< TgridVec, TgridVec > input, u32 lid) (function) of struct shammodels::amr::AMRBlock is not documented.
- src/shammodels/amr/AMRBlock.hpp:124: warning: Member for_each_cell_in_block(Tvec delta_cell, Func &&functor) noexcept (function) of struct shammodels::amr::AMRBlock is not documented.
+ src/shammodels/amr/AMRBlock.hpp:125: warning: Member for_each_cell_in_block(Tvec delta_cell, Func &&functor) noexcept (function) of struct shammodels::amr::AMRBlock is not documented.
- src/shammodels/amr/AMRBlock.hpp:173: warning: Member for_each_cells_lid(sycl::handler &cgh, u32 block_cnt, const char *name, Func &&f) (function) of struct shammodels::amr::AMRBlock is not documented.
+ src/shammodels/amr/AMRBlock.hpp:174: warning: Member for_each_cells_lid(sycl::handler &cgh, u32 block_cnt, const char *name, Func &&f) (function) of struct shammodels::amr::AMRBlock is not documented.
- src/shammodels/amr/AMRBlock.hpp:185: warning: Member for_each_neigh_faces(shamrock::tree::ObjectCacheIterator &block_faces_iter, Acccellcoord acc_block_min, Acccellcoord acc_block_max, const u32 id_a, const shammath::AABB< TgridVec > aabb_cell) (function) of struct shammodels::amr::AMRBlock is not documented.
+ src/shammodels/amr/AMRBlock.hpp:186: warning: Member for_each_neigh_faces(shamrock::tree::ObjectCacheIterator &block_faces_iter, Acccellcoord acc_block_min, Acccellcoord acc_block_max, const u32 id_a, const shammath::AABB< TgridVec > aabb_cell) (function) of struct shammodels::amr::AMRBlock is not documented.
- src/shammodels/amr/AMRBlock.hpp:39: warning: Member Nside (variable) of struct shammodels::amr::AMRBlock is not documented.
+ src/shammodels/amr/AMRBlock.hpp:39: warning: Member NsideBlockPow (variable) of struct shammodels::amr::AMRBlock is not documented.
+ src/shammodels/amr/AMRBlock.hpp:40: warning: Member Nside (variable) of struct shammodels::amr::AMRBlock is not documented.
- src/shammodels/amr/AMRBlock.hpp:40: warning: Member side_size (variable) of struct shammodels::amr::AMRBlock is not documented.
+ src/shammodels/amr/AMRBlock.hpp:41: warning: Member side_size (variable) of struct shammodels::amr::AMRBlock is not documented.
- src/shammodels/amr/AMRBlock.hpp:42: warning: Member block_size (variable) of struct shammodels::amr::AMRBlock is not documented.
+ src/shammodels/amr/AMRBlock.hpp:43: warning: Member block_size (variable) of struct shammodels::amr::AMRBlock is not documented.
- src/shammodels/amr/AMRBlock.hpp:73: warning: Member get_index_relative(std::array< i32, dim > coord) noexcept (function) of struct shammodels::amr::AMRBlock is not documented.
+ src/shammodels/amr/AMRBlock.hpp:74: warning: Member get_index_relative(std::array< i32, dim > coord) noexcept (function) of struct shammodels::amr::AMRBlock is not documented.
- src/shammodels/amr/AMRBlock.hpp:96: warning: Member get_coord(u32 i) noexcept (function) of struct shammodels::amr::AMRBlock is not documented.
+ src/shammodels/amr/AMRBlock.hpp:97: warning: Member get_coord(u32 i) noexcept (function) of struct shammodels::amr::AMRBlock is not documented.
+ src/shammodels/amr/basegodunov/Solver.hpp:100: warning: Member set_eos_gamma(Tscal gamma) (function) of struct shammodels::basegodunov::SolverConfig is not documented.
+ src/shammodels/amr/basegodunov/Solver.hpp:102: warning: Member riemman_config (variable) of struct shammodels::basegodunov::SolverConfig is not documented.
+ src/shammodels/amr/basegodunov/Solver.hpp:103: warning: Member slope_config (variable) of struct shammodels::basegodunov::SolverConfig is not documented.
+ src/shammodels/amr/basegodunov/Solver.hpp:104: warning: Member face_half_time_interpolation (variable) of struct shammodels::basegodunov::SolverConfig is not documented.
+ src/shammodels/amr/basegodunov/Solver.hpp:105: warning: Member dust_config (variable) of struct shammodels::basegodunov::SolverConfig is not documented.
+ src/shammodels/amr/basegodunov/Solver.hpp:107: warning: Member is_dust_on() (function) of struct shammodels::basegodunov::SolverConfig is not documented.
- src/shammodels/amr/basegodunov/Solver.hpp:108: warning: Compound shammodels::basegodunov::Solver is not documented.
+ src/shammodels/amr/basegodunov/Solver.hpp:109: warning: Member Csafe (variable) of struct shammodels::basegodunov::SolverConfig is not documented.
- src/shammodels/amr/basegodunov/Solver.hpp:110: warning: Member Tscal (typedef) of class shammodels::basegodunov::Solver is not documented.
- src/shammodels/amr/basegodunov/Solver.hpp:111: warning: Member Tgridscal (typedef) of class shammodels::basegodunov::Solver is not documented.
- src/shammodels/amr/basegodunov/Solver.hpp:112: warning: Member dim (variable) of class shammodels::basegodunov::Solver is not documented.
- src/shammodels/amr/basegodunov/Solver.hpp:114: warning: Member u_morton (typedef) of class shammodels::basegodunov::Solver is not documented.
- src/shammodels/amr/basegodunov/Solver.hpp:115: warning: Member Config (typedef) of class shammodels::basegodunov::Solver is not documented.
- src/shammodels/amr/basegodunov/Solver.hpp:117: warning: Member AMRBlock (typedef) of class shammodels::basegodunov::Solver is not documented.
- src/shammodels/amr/basegodunov/Solver.hpp:119: warning: Member context (variable) of class shammodels::basegodunov::Solver is not documented.
- src/shammodels/amr/basegodunov/Solver.hpp:120: warning: Member scheduler() (function) of class shammodels::basegodunov::Solver is not documented.
- src/shammodels/amr/basegodunov/Solver.hpp:122: warning: Member solver_config (variable) of class shammodels::basegodunov::Solver is not documented.
- src/shammodels/amr/basegodunov/Solver.hpp:124: warning: Member storage (variable) of class shammodels::basegodunov::Solver is not documented.
- src/shammodels/amr/basegodunov/Solver.hpp:126: warning: Member init_required_fields() (function) of class shammodels::basegodunov::Solver is not documented.
+ src/shammodels/amr/basegodunov/Solver.hpp:129: warning: Compound shammodels::basegodunov::Solver is not documented.
+ src/shammodels/amr/basegodunov/Solver.hpp:131: warning: Member Tscal (typedef) of class shammodels::basegodunov::Solver is not documented.
+ src/shammodels/amr/basegodunov/Solver.hpp:132: warning: Member Tgridscal (typedef) of class shammodels::basegodunov::Solver is not documented.
+ src/shammodels/amr/basegodunov/Solver.hpp:133: warning: Member dim (variable) of class shammodels::basegodunov::Solver is not documented.
+ src/shammodels/amr/basegodunov/Solver.hpp:135: warning: Member u_morton (typedef) of class shammodels::basegodunov::Solver is not documented.
+ src/shammodels/amr/basegodunov/Solver.hpp:136: warning: Member Config (typedef) of class shammodels::basegodunov::Solver is not documented.
+ src/shammodels/amr/basegodunov/Solver.hpp:138: warning: Member AMRBlock (typedef) of class shammodels::basegodunov::Solver is not documented.
+ src/shammodels/amr/basegodunov/Solver.hpp:140: warning: Member context (variable) of class shammodels::basegodunov::Solver is not documented.
- src/shammodels/amr/basegodunov/Solver.hpp:141: warning: Member Solver(ShamrockCtx &context) (function) of class shammodels::basegodunov::Solver is not documented.
+ src/shammodels/amr/basegodunov/Solver.hpp:141: warning: Member scheduler() (function) of class shammodels::basegodunov::Solver is not documented.
- src/shammodels/amr/basegodunov/Solver.hpp:143: warning: Member do_debug_vtk_dump(std::string filename) (function) of class shammodels::basegodunov::Solver is not documented.
+ src/shammodels/amr/basegodunov/Solver.hpp:143: warning: Member solver_config (variable) of class shammodels::basegodunov::Solver is not documented.
- src/shammodels/amr/basegodunov/Solver.hpp:145: warning: Member print_timestep_logs() (function) of class shammodels::basegodunov::Solver is not documented.
+ src/shammodels/amr/basegodunov/Solver.hpp:145: warning: Member storage (variable) of class shammodels::basegodunov::Solver is not documented.
+ src/shammodels/amr/basegodunov/Solver.hpp:147: warning: Member init_required_fields() (function) of class shammodels::basegodunov::Solver is not documented.
- src/shammodels/amr/basegodunov/Solver.hpp:154: warning: Member evolve_once() (function) of class shammodels::basegodunov::Solver is not documented.
- src/shammodels/amr/basegodunov/Solver.hpp:156: warning: Member evolve_once_time_expl(Tscal t_current, Tscal dt_input) (function) of class shammodels::basegodunov::Solver is not documented.
+ src/shammodels/amr/basegodunov/Solver.hpp:162: warning: Member Solver(ShamrockCtx &context) (function) of class shammodels::basegodunov::Solver is not documented.
- src/shammodels/amr/basegodunov/Solver.hpp:163: warning: Member evolve_until(Tscal target_time, i32 niter_max) (function) of class shammodels::basegodunov::Solver is not documented.
+ src/shammodels/amr/basegodunov/Solver.hpp:164: warning: Member do_debug_vtk_dump(std::string filename) (function) of class shammodels::basegodunov::Solver is not documented.
+ src/shammodels/amr/basegodunov/Solver.hpp:166: warning: Member print_timestep_logs() (function) of class shammodels::basegodunov::Solver is not documented.
+ src/shammodels/amr/basegodunov/Solver.hpp:175: warning: Member evolve_once() (function) of class shammodels::basegodunov::Solver is not documented.
+ src/shammodels/amr/basegodunov/Solver.hpp:177: warning: Member evolve_once_time_expl(Tscal t_current, Tscal dt_input) (function) of class shammodels::basegodunov::Solver is not documented.
+ src/shammodels/amr/basegodunov/Solver.hpp:184: warning: Member evolve_until(Tscal target_time, i32 niter_max) (function) of class shammodels::basegodunov::Solver is not documented.
+ src/shammodels/amr/basegodunov/Solver.hpp:71: warning: Compound shammodels::basegodunov::AMRMode is not documented.
- src/shammodels/amr/basegodunov/Solver.hpp:71: warning: Compound shammodels::basegodunov::SolverConfig is not documented.
+ src/shammodels/amr/basegodunov/Solver.hpp:73: warning: Member Tscal (typedef) of struct shammodels::basegodunov::AMRMode is not documented.
- src/shammodels/amr/basegodunov/Solver.hpp:73: warning: Member Tscal (typedef) of struct shammodels::basegodunov::SolverConfig is not documented.
- src/shammodels/amr/basegodunov/Solver.hpp:75: warning: Member eos_gamma (variable) of struct shammodels::basegodunov::SolverConfig is not documented.
+ src/shammodels/amr/basegodunov/Solver.hpp:76: warning: Compound shammodels::basegodunov::AMRMode::DensityBased is not documented.
+ src/shammodels/amr/basegodunov/Solver.hpp:77: warning: Member crit_mass (variable) of struct shammodels::basegodunov::AMRMode::DensityBased is not documented.
- src/shammodels/amr/basegodunov/Solver.hpp:77: warning: Member grid_coord_to_pos_fact (variable) of struct shammodels::basegodunov::SolverConfig is not documented.
- src/shammodels/amr/basegodunov/Solver.hpp:79: warning: Member NsideBlockPow (variable) of struct shammodels::basegodunov::SolverConfig is not documented.
- src/shammodels/amr/basegodunov/Solver.hpp:80: warning: Member AMRBlock (typedef) of struct shammodels::basegodunov::SolverConfig is not documented.
+ src/shammodels/amr/basegodunov/Solver.hpp:80: warning: Member mode (typedef) of struct shammodels::basegodunov::AMRMode is not documented.
+ src/shammodels/amr/basegodunov/Solver.hpp:82: warning: Member config (variable) of struct shammodels::basegodunov::AMRMode is not documented.
- src/shammodels/amr/basegodunov/Solver.hpp:82: warning: Member set_eos_gamma(Tscal gamma) (function) of struct shammodels::basegodunov::SolverConfig is not documented.
- src/shammodels/amr/basegodunov/Solver.hpp:84: warning: Member riemman_config (variable) of struct shammodels::basegodunov::SolverConfig is not documented.
+ src/shammodels/amr/basegodunov/Solver.hpp:84: warning: Member set_refine_none() (function) of struct shammodels::basegodunov::AMRMode is not documented.
+ src/shammodels/amr/basegodunov/Solver.hpp:85: warning: Member set_refine_density_based(Tscal crit_mass) (function) of struct shammodels::basegodunov::AMRMode is not documented.
- src/shammodels/amr/basegodunov/Solver.hpp:85: warning: Member slope_config (variable) of struct shammodels::basegodunov::SolverConfig is not documented.
- src/shammodels/amr/basegodunov/Solver.hpp:86: warning: Member face_half_time_interpolation (variable) of struct shammodels::basegodunov::SolverConfig is not documented.
- src/shammodels/amr/basegodunov/Solver.hpp:87: warning: Member dust_config (variable) of struct shammodels::basegodunov::SolverConfig is not documented.
+ src/shammodels/amr/basegodunov/Solver.hpp:89: warning: Compound shammodels::basegodunov::SolverConfig is not documented.
- src/shammodels/amr/basegodunov/Solver.hpp:89: warning: Member is_dust_on() (function) of struct shammodels::basegodunov::SolverConfig is not documented.
- src/shammodels/amr/basegodunov/Solver.hpp:91: warning: Member Csafe (variable) of struct shammodels::basegodunov::SolverConfig is not documented.
+ src/shammodels/amr/basegodunov/Solver.hpp:91: warning: Member Tscal (typedef) of struct shammodels::basegodunov::SolverConfig is not documented.
+ src/shammodels/amr/basegodunov/Solver.hpp:93: warning: Member eos_gamma (variable) of struct shammodels::basegodunov::SolverConfig is not documented.
+ src/shammodels/amr/basegodunov/Solver.hpp:95: warning: Member grid_coord_to_pos_fact (variable) of struct shammodels::basegodunov::SolverConfig is not documented.
+ src/shammodels/amr/basegodunov/Solver.hpp:97: warning: Member NsideBlockPow (variable) of struct shammodels::basegodunov::SolverConfig is not documented.
+ src/shammodels/amr/basegodunov/Solver.hpp:98: warning: Member AMRBlock (typedef) of struct shammodels::basegodunov::SolverConfig is not documented.
- src/shammodels/amr/basegodunov/modules/AMRGraphGen.cpp:238: warning: Member for_each_other_index(u32 id_a, IndexFunctor &&fct) const (function) of class shammodels::basegodunov::modules::AMRGraphGen::AMRLowering is not documented.
+ src/shammodels/amr/basegodunov/modules/AMRGraphGen.cpp:238: warning: Member for_each_other_index_safe(u32 id_a, IndexFunctor &&fct) const (function) of class shammodels::basegodunov::modules::AMRGraphGen::AMRLowering is not documented.
+ src/shammodels/amr/basegodunov/modules/AMRGraphGen.cpp:304: warning: Member for_each_other_index_full(u32 id_a, IndexFunctor &&fct) const (function) of class shammodels::basegodunov::modules::AMRGraphGen::AMRLowering is not documented.
+ src/shammodels/amr/basegodunov/modules/AMRGraphGen.cpp:417: warning: Member for_each_other_index(u32 id_a, IndexFunctor &&fct) const (function) of class shammodels::basegodunov::modules::AMRGraphGen::AMRLowering is not documented.
+ src/shammodels/amr/basegodunov/modules/AMRGridRefinementHandler.hpp:26: warning: Compound shammodels::basegodunov::modules::OptIndexList is not documented.
+ src/shammodels/amr/basegodunov/modules/AMRGridRefinementHandler.hpp:27: warning: Member idx (variable) of struct shammodels::basegodunov::modules::OptIndexList is not documented.
+ src/shammodels/amr/basegodunov/modules/AMRGridRefinementHandler.hpp:28: warning: Member count (variable) of struct shammodels::basegodunov::modules::OptIndexList is not documented.
+ src/shammodels/amr/basegodunov/modules/AMRGridRefinementHandler.hpp:32: warning: Compound shammodels::basegodunov::modules::AMRGridRefinementHandler is not documented.
+ src/shammodels/amr/basegodunov/modules/AMRGridRefinementHandler.hpp:38: warning: Member Tscal (typedef) of class shammodels::basegodunov::modules::AMRGridRefinementHandler is not documented.
+ src/shammodels/amr/basegodunov/modules/AMRGridRefinementHandler.hpp:39: warning: Member Tgridscal (typedef) of class shammodels::basegodunov::modules::AMRGridRefinementHandler is not documented.
+ src/shammodels/amr/basegodunov/modules/AMRGridRefinementHandler.hpp:40: warning: Member dim (variable) of class shammodels::basegodunov::modules::AMRGridRefinementHandler is not documented.
+ src/shammodels/amr/basegodunov/modules/AMRGridRefinementHandler.hpp:41: warning: Member split_count (variable) of class shammodels::basegodunov::modules::AMRGridRefinementHandler is not documented.
+ src/shammodels/amr/basegodunov/modules/AMRGridRefinementHandler.hpp:43: warning: Member Config (typedef) of class shammodels::basegodunov::modules::AMRGridRefinementHandler is not documented.
+ src/shammodels/amr/basegodunov/modules/AMRGridRefinementHandler.hpp:44: warning: Member Storage (typedef) of class shammodels::basegodunov::modules::AMRGridRefinementHandler is not documented.
+ src/shammodels/amr/basegodunov/modules/AMRGridRefinementHandler.hpp:45: warning: Member u_morton (typedef) of class shammodels::basegodunov::modules::AMRGridRefinementHandler is not documented.
+ src/shammodels/amr/basegodunov/modules/AMRGridRefinementHandler.hpp:46: warning: Member AMRBlock (typedef) of class shammodels::basegodunov::modules::AMRGridRefinementHandler is not documented.
+ src/shammodels/amr/basegodunov/modules/AMRGridRefinementHandler.hpp:47: warning: Member BlockCoord (typedef) of class shammodels::basegodunov::modules::AMRGridRefinementHandler is not documented.
+ src/shammodels/amr/basegodunov/modules/AMRGridRefinementHandler.hpp:48: warning: Member OrientedAMRGraph (typedef) of class shammodels::basegodunov::modules::AMRGridRefinementHandler is not documented.
+ src/shammodels/amr/basegodunov/modules/AMRGridRefinementHandler.hpp:50: warning: Member context (variable) of class shammodels::basegodunov::modules::AMRGridRefinementHandler is not documented.
+ src/shammodels/amr/basegodunov/modules/AMRGridRefinementHandler.hpp:51: warning: Member solver_config (variable) of class shammodels::basegodunov::modules::AMRGridRefinementHandler is not documented.
+ src/shammodels/amr/basegodunov/modules/AMRGridRefinementHandler.hpp:52: warning: Member storage (variable) of class shammodels::basegodunov::modules::AMRGridRefinementHandler is not documented.
+ src/shammodels/amr/basegodunov/modules/AMRGridRefinementHandler.hpp:54: warning: Member AMRGridRefinementHandler(ShamrockCtx &context, Config &solver_config, Storage &storage) (function) of class shammodels::basegodunov::modules::AMRGridRefinementHandler is not documented.
+ src/shammodels/amr/basegodunov/modules/AMRGridRefinementHandler.hpp:57: warning: Member update_refinement() (function) of class shammodels::basegodunov::modules::AMRGridRefinementHandler is not documented.
+ src/shammodels/amr/basegodunov/modules/AMRSortBlocks.hpp:27: warning: Compound shammodels::basegodunov::modules::AMRSortBlocks is not documented.
+ src/shammodels/amr/basegodunov/modules/AMRSortBlocks.hpp:30: warning: Member Tscal (typedef) of class shammodels::basegodunov::modules::AMRSortBlocks is not documented.
+ src/shammodels/amr/basegodunov/modules/AMRSortBlocks.hpp:31: warning: Member Tgridscal (typedef) of class shammodels::basegodunov::modules::AMRSortBlocks is not documented.
+ src/shammodels/amr/basegodunov/modules/AMRSortBlocks.hpp:32: warning: Member dim (variable) of class shammodels::basegodunov::modules::AMRSortBlocks is not documented.
+ src/shammodels/amr/basegodunov/modules/AMRSortBlocks.hpp:33: warning: Member split_count (variable) of class shammodels::basegodunov::modules::AMRSortBlocks is not documented.
+ src/shammodels/amr/basegodunov/modules/AMRSortBlocks.hpp:35: warning: Member Config (typedef) of class shammodels::basegodunov::modules::AMRSortBlocks is not documented.
+ src/shammodels/amr/basegodunov/modules/AMRSortBlocks.hpp:36: warning: Member Storage (typedef) of class shammodels::basegodunov::modules::AMRSortBlocks is not documented.
+ src/shammodels/amr/basegodunov/modules/AMRSortBlocks.hpp:37: warning: Member u_morton (typedef) of class shammodels::basegodunov::modules::AMRSortBlocks is not documented.
+ src/shammodels/amr/basegodunov/modules/AMRSortBlocks.hpp:38: warning: Member AMRBlock (typedef) of class shammodels::basegodunov::modules::AMRSortBlocks is not documented.
+ src/shammodels/amr/basegodunov/modules/AMRSortBlocks.hpp:39: warning: Member BlockCoord (typedef) of class shammodels::basegodunov::modules::AMRSortBlocks is not documented.
+ src/shammodels/amr/basegodunov/modules/AMRSortBlocks.hpp:40: warning: Member OrientedAMRGraph (typedef) of class shammodels::basegodunov::modules::AMRSortBlocks is not documented.
+ src/shammodels/amr/basegodunov/modules/AMRSortBlocks.hpp:42: warning: Member context (variable) of class shammodels::basegodunov::modules::AMRSortBlocks is not documented.
+ src/shammodels/amr/basegodunov/modules/AMRSortBlocks.hpp:43: warning: Member solver_config (variable) of class shammodels::basegodunov::modules::AMRSortBlocks is not documented.
+ src/shammodels/amr/basegodunov/modules/AMRSortBlocks.hpp:44: warning: Member storage (variable) of class shammodels::basegodunov::modules::AMRSortBlocks is not documented.
+ src/shammodels/amr/basegodunov/modules/AMRSortBlocks.hpp:46: warning: Member AMRSortBlocks(ShamrockCtx &context, Config &solver_config, Storage &storage) (function) of class shammodels::basegodunov::modules::AMRSortBlocks is not documented.
+ src/shammodels/amr/basegodunov/modules/AMRSortBlocks.hpp:49: warning: Member reorder_amr_blocks() (function) of class shammodels::basegodunov::modules::AMRSortBlocks is not documented.
- src/shammodels/bindings/pyAMRGodunovModel.cpp:171: warning: Member Register_pymod(pybasegodunovmodel) (function) of file pyAMRGodunovModel.cpp is not documented.
+ src/shammodels/bindings/pyAMRGodunovModel.cpp:185: warning: Member Register_pymod(pybasegodunovmodel) (function) of file pyAMRGodunovModel.cpp is not documented.
- src/shamrock/amr/AMRCell.hpp:100: warning: Member split() (function) of class shamrock::amr::AMRCellCoord is not documented.
- src/shamrock/amr/AMRCell.hpp:102: warning: Member get_merge(AMRCellCoord c1, AMRCellCoord c2) (function) of class shamrock::amr::AMRCellCoord is not documented.
- src/shamrock/amr/AMRCell.hpp:106: warning: Member get_merge(std::array< AMRCellCoord, splts_count > others) (function) of class shamrock::amr::AMRCellCoord is not documented.
- src/shamrock/amr/AMRCell.hpp:116: warning: Member are_mergeable(std::array< AMRCellCoord, splts_count > others) (function) of class shamrock::amr::AMRCellCoord is not documented.
- src/shamrock/amr/AMRCell.hpp:24: warning: Compound shamrock::amr::AMRCellCoord is not documented.
+ src/shamrock/amr/AMRCell.hpp:25: warning: Compound shamrock::amr::AMRBlockCoord is not documented.
- src/shamrock/amr/AMRCell.hpp:27: warning: Member splts_count (variable) of class shamrock::amr::AMRCellCoord is not documented.
- src/shamrock/amr/AMRCell.hpp:28: warning: Member bmax (variable) of class shamrock::amr::AMRCellCoord is not documented.
- src/shamrock/amr/AMRCell.hpp:28: warning: Member bmin (variable) of class shamrock::amr::AMRCellCoord is not documented.
+ src/shamrock/amr/AMRCell.hpp:28: warning: Member splts_count (variable) of class shamrock::amr::AMRBlockCoord is not documented.
+ src/shamrock/amr/AMRCell.hpp:29: warning: Member bmax (variable) of class shamrock::amr::AMRBlockCoord is not documented.
+ src/shamrock/amr/AMRCell.hpp:29: warning: Member bmin (variable) of class shamrock::amr::AMRBlockCoord is not documented.
- src/shamrock/amr/AMRCell.hpp:30: warning: Member get_split_coord(Tcoord bmin, Tcoord bmax) -> Tcoord (function) of class shamrock::amr::AMRCellCoord is not documented.
+ src/shamrock/amr/AMRCell.hpp:31: warning: Member get_split_coord(Tcoord bmin, Tcoord bmax) -> Tcoord (function) of class shamrock::amr::AMRBlockCoord is not documented.
- src/shamrock/amr/AMRCell.hpp:35: warning: Member get_split(Tcoord bmin, Tcoord bmax) -> std::array< AMRCellCoord, splts_count > (function) of class shamrock::amr::AMRCellCoord is not documented.
+ src/shamrock/amr/AMRCell.hpp:36: warning: Member get_split(Tcoord bmin, Tcoord bmax) -> std::array< AMRBlockCoord, splts_count > (function) of class shamrock::amr::AMRBlockCoord is not documented.
+ src/shamrock/amr/AMRCell.hpp:66: warning: Member split() (function) of class shamrock::amr::AMRBlockCoord is not documented.
+ src/shamrock/amr/AMRCell.hpp:68: warning: Member get_merge(AMRBlockCoord c1, AMRBlockCoord c2) (function) of class shamrock::amr::AMRBlockCoord is not documented.
+ src/shamrock/amr/AMRCell.hpp:72: warning: Member get_merge(std::array< AMRBlockCoord, splts_count > others) (function) of class shamrock::amr::AMRBlockCoord is not documented.
+ src/shamrock/amr/AMRCell.hpp:82: warning: Member are_mergeable(std::array< AMRBlockCoord, splts_count > others) (function) of class shamrock::amr::AMRBlockCoord is not documented.

tdavidcl and others added 10 commits October 6, 2024 22:51

[AMR] add refine algorithm

a00f7b9

[AMR] add derefine alg

d9c0b29

[AMR] implement (de)refine list gen algs

9745a3d

[AMR] document the refinment handling procedure to be implemented

4fa77ee

[AMR] connect refine and derefine alg to refine utility

987174a

[AMR] finalize the refinment interface

a40a161

[AMR][Godunov] working refine but solver is crashing

8dc0748

[AMR][Godunov] working refine but solver is crashing

f97c81a

[AMR][Godunov] workign refine

7435ab8

[AMR][Godunov] sod working

90e13f1

tdavidcl changed the title ~~[AMR][Godunov] grid refinement utilities~~ [AMR][Godunov] enable grid refinement Oct 11, 2024

tdavidcl added 2 commits October 11, 2024 16:42

[AMR][Godunov] refinement config in amr config

9a7770e

[AMR][Godunov] document some choices in the funcs

1b359f3

tdavidcl added the in-review label Oct 11, 2024

tdavidcl merged commit ec7b905 into main Oct 11, 2024

tdavidcl deleted the feature/enable-amr-refine branch October 11, 2024 17:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AMR][Godunov] enable grid refinement#632

[AMR][Godunov] enable grid refinement#632
tdavidcl merged 12 commits intomainfrom
feature/enable-amr-refine

tdavidcl commented Oct 6, 2024 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 11, 2024

Uh oh!

github-actions Bot commented Oct 11, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

tdavidcl commented Oct 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

AMR refinement

Possible regressions

Uh oh!

github-actions Bot commented Oct 11, 2024

Uh oh!

github-actions Bot commented Oct 11, 2024

Doxygen diff with main

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

tdavidcl commented Oct 6, 2024 •

edited

Loading

Doxygen diff with `main`