[Patch] migrate PatchDataFields from sycl::buffer to USM allocations#672
Merged
[Patch] migrate PatchDataFields from sycl::buffer to USM allocations#672
Conversation
Member
Author
|
Additional migration of Neigh caches was forced because of the buffer synchronization rules preventing memory free of the neigh cache leading to doubling of memory consumption. |
Contributor
|
Pre-commit check: ✅ Test pipeline can run. |
Contributor
Cland tidy diff reportSuggested changesDetailed changes : |
Contributor
Doxygen diff with
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration to USM part 1
This PR migrate from using ResizableBuffer (sycl::buffer based) class to DeviceBuffer class (USM alloc based) for its storage.
Effectively this means that all patch related allocations are now USM instead of buffers implying most likely increase in perf and flexibility.
HOWEVER, such change cascade into a endless PR since that single line change resulted in more than 8k lines of changes ... bruh ...
TODOs
Perf tests
Tests SPH solver configurations
Tests AMR solver configurations
Tests Zeus solver configurations
Tests Nbody solver configurations