Skip to content

[Dump] remove wrong offset in dump#694

Merged
tdavidcl merged 2 commits intomainfrom
feature/remove-dump-offset
Dec 11, 2024
Merged

[Dump] remove wrong offset in dump#694
tdavidcl merged 2 commits intomainfrom
feature/remove-dump-offset

Conversation

@tdavidcl
Copy link
Copy Markdown
Member

This pr remove the offset between the dump header and the content of the buffers.
This was originally created by forgetting to reset the MPI file view before writing the buffers.
After this PR you can set the environment variable SHAMDUMP_OFFSET_MODE_OLD=1 to fallback to the old mode

@github-actions
Copy link
Copy Markdown
Contributor

Pre-commit check: ✅

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check yaml...............................................................Passed
detect private key.......................................................Passed
Validate GitHub Workflows................................................Passed
clang-format.............................................................Passed
Check doxygen headers....................................................Passed
Check license headers....................................................Passed
Check #pragma once.......................................................Passed
Check SYCL #include......................................................Passed

Test pipeline can run.

@github-actions
Copy link
Copy Markdown
Contributor

Cland tidy diff report


3 warnings generated.
Suppressed 3 warnings (3 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

Suggested changes

Detailed changes :

@github-actions
Copy link
Copy Markdown
Contributor

Doxygen diff with main

Removed warnings : 0
New warnings : 0
Warnings count : 5726 → 5726 (0.0%)

Detailed changes :

@tdavidcl tdavidcl merged commit f446fd3 into main Dec 11, 2024
@tdavidcl tdavidcl deleted the feature/remove-dump-offset branch December 11, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant