Skip to content

[Fix] rewrite mock_field & add zero size guards#727

Merged
tdavidcl merged 2 commits intomainfrom
fix/patchdata_mock
Dec 29, 2024
Merged

[Fix] rewrite mock_field & add zero size guards#727
tdavidcl merged 2 commits intomainfrom
fix/patchdata_mock

Conversation

@tdavidcl
Copy link
Copy Markdown
Member

Fix : #726

Additionally, add guards on zero sized buffers and rewrite mock_field to avoid sycl::buffer(s)

@github-actions
Copy link
Copy Markdown
Contributor

Pre-commit check: ✅

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check yaml...............................................................Passed
detect private key.......................................................Passed
Validate GitHub Workflows................................................Passed
clang-format.............................................................Passed
Check doxygen headers....................................................Passed
Check license headers....................................................Passed
Check #pragma once.......................................................Passed
Check SYCL #include......................................................Passed

Test pipeline can run.

@github-actions
Copy link
Copy Markdown
Contributor

Cland tidy diff report


3 warnings generated.
Suppressed 3 warnings (3 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

Suggested changes

Detailed changes :

@github-actions
Copy link
Copy Markdown
Contributor

Doxygen diff with main

Removed warnings : 15
New warnings : 15
Warnings count : 5497 → 5497 (0.0%)

Detailed changes :
+ src/shammodels/amr/NeighGraphLinkField.hpp:26: warning: Compound shammodels::basegodunov::modules::NeighGraphLinkField is not documented.
- src/shammodels/amr/NeighGraphLinkField.hpp:28: warning: Compound shammodels::basegodunov::modules::NeighGraphLinkField is not documented.
+ src/shammodels/amr/NeighGraphLinkField.hpp:28: warning: Member link_graph_field (variable) of class shammodels::basegodunov::modules::NeighGraphLinkField is not documented.
+ src/shammodels/amr/NeighGraphLinkField.hpp:29: warning: Member link_count (variable) of class shammodels::basegodunov::modules::NeighGraphLinkField is not documented.
- src/shammodels/amr/NeighGraphLinkField.hpp:30: warning: Member link_graph_field (variable) of class shammodels::basegodunov::modules::NeighGraphLinkField is not documented.
+ src/shammodels/amr/NeighGraphLinkField.hpp:30: warning: Member nvar (variable) of class shammodels::basegodunov::modules::NeighGraphLinkField is not documented.
- src/shammodels/amr/NeighGraphLinkField.hpp:31: warning: Member link_count (variable) of class shammodels::basegodunov::modules::NeighGraphLinkField is not documented.
+ src/shammodels/amr/NeighGraphLinkField.hpp:32: warning: Member NeighGraphLinkField(NeighGraph &graph) (function) of class shammodels::basegodunov::modules::NeighGraphLinkField is not documented.
- src/shammodels/amr/NeighGraphLinkField.hpp:32: warning: Member nvar (variable) of class shammodels::basegodunov::modules::NeighGraphLinkField is not documented.
- src/shammodels/amr/NeighGraphLinkField.hpp:34: warning: Member NeighGraphLinkField(NeighGraph &graph) (function) of class shammodels::basegodunov::modules::NeighGraphLinkField is not documented.
+ src/shammodels/amr/NeighGraphLinkField.hpp:35: warning: Member NeighGraphLinkField(NeighGraph &graph, u32 nvar) (function) of class shammodels::basegodunov::modules::NeighGraphLinkField is not documented.
- src/shammodels/amr/NeighGraphLinkField.hpp:38: warning: Member NeighGraphLinkField(NeighGraph &graph, u32 nvar) (function) of class shammodels::basegodunov::modules::NeighGraphLinkField is not documented.
+ src/shammodels/amr/NeighGraphLinkField.hpp:40: warning: Member compute_link_field(sham::DeviceQueue &q, sham::EventList &depends_list, sham::EventList &result_list, NeighGraph &graph, Args &&...args) (function) of namespace shammodels::basegodunov::modules is not documented.
+ src/shammodels/amr/NeighGraphLinkField.hpp:40: warning: Member compute_link_field(sham::DeviceQueue &q, sham::EventList &depends_list, sham::EventList &result_list, NeighGraph &graph, Args &&...args) (function) of namespace shammodels::basegodunov::modules is not documented.
- src/shammodels/amr/NeighGraphLinkField.hpp:44: warning: Member compute_link_field(sham::DeviceQueue &q, sham::EventList &depends_list, sham::EventList &result_list, NeighGraph &graph, Args &&...args) (function) of namespace shammodels::basegodunov::modules is not documented.
- src/shammodels/amr/NeighGraphLinkField.hpp:44: warning: Member compute_link_field(sham::DeviceQueue &q, sham::EventList &depends_list, sham::EventList &result_list, NeighGraph &graph, Args &&...args) (function) of namespace shammodels::basegodunov::modules is not documented.
+ src/shammodels/amr/NeighGraphLinkField.hpp:68: warning: Member compute_link_field_indep_nvar(sham::DeviceQueue &q, sham::EventList &depends_list, sham::EventList &result_list, NeighGraph &graph, u32 nvar, Args &&...args) (function) of namespace shammodels::basegodunov::modules is not documented.
+ src/shammodels/amr/NeighGraphLinkField.hpp:68: warning: Member compute_link_field_indep_nvar(sham::DeviceQueue &q, sham::EventList &depends_list, sham::EventList &result_list, NeighGraph &graph, u32 nvar, Args &&...args) (function) of namespace shammodels::basegodunov::modules is not documented.
- src/shammodels/amr/NeighGraphLinkField.hpp:73: warning: Member compute_link_field_indep_nvar(sham::DeviceQueue &q, sham::EventList &depends_list, sham::EventList &result_list, NeighGraph &graph, u32 nvar, Args &&...args) (function) of namespace shammodels::basegodunov::modules is not documented.
- src/shammodels/amr/NeighGraphLinkField.hpp:73: warning: Member compute_link_field_indep_nvar(sham::DeviceQueue &q, sham::EventList &depends_list, sham::EventList &result_list, NeighGraph &graph, u32 nvar, Args &&...args) (function) of namespace shammodels::basegodunov::modules is not documented.
- src/shammodels/amr/basegodunov/modules/ComputeFluxUtilities.hpp:166: warning: Member compute_fluxes_dir(sham::DeviceQueue &q, u32 link_count, sham::DeviceBuffer< std::array< Tscal, 2 > > &rho_face_dir, sham::DeviceBuffer< std::array< Tvec, 2 > > &vel_face_dir, sham::DeviceBuffer< std::array< Tscal, 2 > > &press_face_dir, sham::DeviceBuffer< Tscal > &flux_rho_face_dir, sham::DeviceBuffer< Tvec > &flux_rhov_face_dir, sham::DeviceBuffer< Tscal > &flux_rhoe_face_dir, Tscal gamma) (function) of namespace shammodels::basegodunov::modules is not documented.
- src/shammodels/amr/basegodunov/modules/ComputeFluxUtilities.hpp:166: warning: Member compute_fluxes_dir(sham::DeviceQueue &q, u32 link_count, sham::DeviceBuffer< std::array< Tscal, 2 > > &rho_face_dir, sham::DeviceBuffer< std::array< Tvec, 2 > > &vel_face_dir, sham::DeviceBuffer< std::array< Tscal, 2 > > &press_face_dir, sham::DeviceBuffer< Tscal > &flux_rho_face_dir, sham::DeviceBuffer< Tvec > &flux_rhov_face_dir, sham::DeviceBuffer< Tscal > &flux_rhoe_face_dir, Tscal gamma) (function) of namespace shammodels::basegodunov::modules is not documented.
+ src/shammodels/amr/basegodunov/modules/ComputeFluxUtilities.hpp:166: warning: Member compute_fluxes_dir(sycl::queue &q, u32 link_count, sycl::buffer< std::array< Tscal, 2 > > &rho_face_dir, sycl::buffer< std::array< Tvec, 2 > > &vel_face_dir, sycl::buffer< std::array< Tscal, 2 > > &press_face_dir, sycl::buffer< Tscal > &flux_rho_face_dir, sycl::buffer< Tvec > &flux_rhov_face_dir, sycl::buffer< Tscal > &flux_rhoe_face_dir, Tscal gamma) (function) of namespace shammodels::basegodunov::modules is not documented.
+ src/shammodels/amr/basegodunov/modules/ComputeFluxUtilities.hpp:166: warning: Member compute_fluxes_dir(sycl::queue &q, u32 link_count, sycl::buffer< std::array< Tscal, 2 > > &rho_face_dir, sycl::buffer< std::array< Tvec, 2 > > &vel_face_dir, sycl::buffer< std::array< Tscal, 2 > > &press_face_dir, sycl::buffer< Tscal > &flux_rho_face_dir, sycl::buffer< Tvec > &flux_rhov_face_dir, sycl::buffer< Tscal > &flux_rhoe_face_dir, Tscal gamma) (function) of namespace shammodels::basegodunov::modules is not documented.
+ src/shammodels/amr/basegodunov/modules/ComputeFluxUtilities.hpp:235: warning: Member dust_compute_fluxes_dir(sycl::queue &q, u32 link_count, sycl::buffer< std::array< Tscal, 2 > > &rho_dust_dir, sycl::buffer< std::array< Tvec, 2 > > &vel_dust_dir, sycl::buffer< Tscal > &flux_rho_dust_dir, sycl::buffer< Tvec > &flux_rhov_dust_dir, u32 nvar) (function) of namespace shammodels::basegodunov::modules is not documented.
+ src/shammodels/amr/basegodunov/modules/ComputeFluxUtilities.hpp:235: warning: Member dust_compute_fluxes_dir(sycl::queue &q, u32 link_count, sycl::buffer< std::array< Tscal, 2 > > &rho_dust_dir, sycl::buffer< std::array< Tvec, 2 > > &vel_dust_dir, sycl::buffer< Tscal > &flux_rho_dust_dir, sycl::buffer< Tvec > &flux_rhov_dust_dir, u32 nvar) (function) of namespace shammodels::basegodunov::modules is not documented.
- src/shammodels/amr/basegodunov/modules/ComputeFluxUtilities.hpp:244: warning: Member dust_compute_fluxes_dir(sham::DeviceQueue &q, u32 link_count, sham::DeviceBuffer< std::array< Tscal, 2 > > &rho_dust_dir, sham::DeviceBuffer< std::array< Tvec, 2 > > &vel_dust_dir, sham::DeviceBuffer< Tscal > &flux_rho_dust_dir, sham::DeviceBuffer< Tvec > &flux_rhov_dust_dir, u32 nvar) (function) of namespace shammodels::basegodunov::modules is not documented.
- src/shammodels/amr/basegodunov/modules/ComputeFluxUtilities.hpp:244: warning: Member dust_compute_fluxes_dir(sham::DeviceQueue &q, u32 link_count, sham::DeviceBuffer< std::array< Tscal, 2 > > &rho_dust_dir, sham::DeviceBuffer< std::array< Tvec, 2 > > &vel_dust_dir, sham::DeviceBuffer< Tscal > &flux_rho_dust_dir, sham::DeviceBuffer< Tvec > &flux_rhov_dust_dir, u32 nvar) (function) of namespace shammodels::basegodunov::modules is not documented.
+ src/shamrock/src/patch/PatchDataField.cpp:484: warning: Member obj_mock_cnt (variable) of file PatchDataField.cpp is not documented.
- src/shamrock/src/patch/PatchDataField.cpp:485: warning: Member obj_mock_cnt (variable) of file PatchDataField.cpp is not documented.

@tdavidcl tdavidcl merged commit b653a5e into main Dec 29, 2024
@tdavidcl tdavidcl deleted the fix/patchdata_mock branch December 29, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Test] shamrock/patch/PatchDataField::get_ids_..._where fail on dpc++ CUDA backend

1 participant