Skip to content

[Main] introduce --smi arg to list all possible compute devices directly with shamrock#830

Merged
tdavidcl merged 10 commits intomainfrom
feat/sham-smi
Mar 1, 2025
Merged

[Main] introduce --smi arg to list all possible compute devices directly with shamrock#830
tdavidcl merged 10 commits intomainfrom
feat/sham-smi

Conversation

@tdavidcl
Copy link
Copy Markdown
Member

  • introduce shamrock --smi to list all available devices
    Screenshot_20250228_223038

  • Remap internal functions in node instance

@tdavidcl tdavidcl linked an issue Feb 28, 2025 that may be closed by this pull request
@tdavidcl tdavidcl linked an issue Mar 1, 2025 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 1, 2025

Workflow report

workflow report corresponding to commit 23b9e0d
Commiter email is timothee.davidcleris@proton.me

Pre-commit check report

Pre-commit check: ✅

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check yaml...............................................................Passed
detect private key.......................................................Passed
Validate GitHub Workflows................................................Passed
clang-format.............................................................Passed
Check doxygen headers....................................................Passed
Check license headers....................................................Passed
Check #pragma once.......................................................Passed
Check SYCL #include......................................................Passed

Test pipeline can run.

Clang-tidy diff report

No relevant changes found.
Well done!

You should now go back to your normal life and enjoy a hopefully sunny day while waiting for the review.

Doxygen diff with main

Removed warnings : 45
New warnings : 47
Warnings count : 5675 → 5677 (0.0%)

Detailed changes :
- src/main.cpp:53: warning: Member main(int argc, char *argv[]) (function) of file main.cpp is not documented.
+ src/main.cpp:54: warning: Member main(int argc, char *argv[]) (function) of file main.cpp is not documented.
- src/main_test.cpp:28: warning: Member main(int argc, char *argv[]) (function) of file main_test.cpp is not documented.
+ src/main_test.cpp:29: warning: Member main(int argc, char *argv[]) (function) of file main_test.cpp is not documented.
+ src/shamsys/include/shamsys/NodeInstance.hpp:119: warning: Member get_compute_device() (function) of namespace shamsys::instance is not documented.
- src/shamsys/include/shamsys/NodeInstance.hpp:139: warning: Member get_compute_device() (function) of namespace shamsys::instance is not documented.
+ src/shamsys/include/shamsys/device_select.hpp:23: warning: Compound shamsys::DeviceSelectRet_t is not documented.
+ src/shamsys/include/shamsys/device_select.hpp:25: warning: Member device_compute (variable) of struct shamsys::DeviceSelectRet_t is not documented.
+ src/shamsys/include/shamsys/device_select.hpp:26: warning: Member device_alt (variable) of struct shamsys::DeviceSelectRet_t is not documented.
+ src/shamsys/src/NodeInstance.cpp:101: warning: Member ctx_compute (variable) of namespace syclinit is not documented.
+ src/shamsys/src/NodeInstance.cpp:102: warning: Member ctx_alt (variable) of namespace syclinit is not documented.
+ src/shamsys/src/NodeInstance.cpp:104: warning: Member sched_compute (variable) of namespace syclinit is not documented.
+ src/shamsys/src/NodeInstance.cpp:105: warning: Member sched_alt (variable) of namespace syclinit is not documented.
+ src/shamsys/src/NodeInstance.cpp:107: warning: Member init_device_scheduling() (function) of namespace syclinit is not documented.
+ src/shamsys/src/NodeInstance.cpp:124: warning: Member init_queues(std::string search_key) (function) of namespace syclinit is not documented.
+ src/shamsys/src/NodeInstance.cpp:136: warning: Member finalize() (function) of namespace syclinit is not documented.
+ src/shamsys/src/NodeInstance.cpp:152: warning: Member compute_queue_eu_count (variable) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:154: warning: Member get_compute_queue_eu_count(u32 id=0) (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:154: warning: Member get_compute_queue_eu_count(u32 id=0) (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:158: warning: Member print_queue_map() (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:158: warning: Member print_queue_map() (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:196: warning: Member print_device_list_debug() (function) of namespace shamsys::instance::tmp is not documented.
+ src/shamsys/src/NodeInstance.cpp:218: warning: Member start_sycl_auto(std::string search_key) (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:219: warning: Member exception_gen_callback(std::string msg) (function) of namespace logformatter is not documented.
- src/shamsys/src/NodeInstance.cpp:219: warning: Member exception_gen_callback(std::string msg) (function) of namespace logformatter is not documented.
+ src/shamsys/src/NodeInstance.cpp:232: warning: Member start_mpi(MPIInitInfo mpi_info) (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:232: warning: Member start_mpi(MPIInitInfo mpi_info) (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:248: warning: Member print_device_list() (function) of namespace shamsys::instance::details is not documented.
+ src/shamsys/src/NodeInstance.cpp:282: warning: Member init_sycl_mpi(std::string search_key, MPIInitInfo mpi_info) (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:282: warning: Member init_sycl_mpi(std::string search_key, MPIInitInfo mpi_info) (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:293: warning: Member initialized (variable) of namespace syclinit is not documented.
- src/shamsys/src/NodeInstance.cpp:295: warning: Member device_compute (variable) of namespace syclinit is not documented.
- src/shamsys/src/NodeInstance.cpp:296: warning: Member device_alt (variable) of namespace syclinit is not documented.
- src/shamsys/src/NodeInstance.cpp:298: warning: Member ctx_compute (variable) of namespace syclinit is not documented.
- src/shamsys/src/NodeInstance.cpp:299: warning: Member ctx_alt (variable) of namespace syclinit is not documented.
- src/shamsys/src/NodeInstance.cpp:301: warning: Member sched_compute (variable) of namespace syclinit is not documented.
- src/shamsys/src/NodeInstance.cpp:302: warning: Member sched_alt (variable) of namespace syclinit is not documented.
- src/shamsys/src/NodeInstance.cpp:304: warning: Member init_device_scheduling() (function) of namespace syclinit is not documented.
- src/shamsys/src/NodeInstance.cpp:321: warning: Member init_queues_auto(std::string search_key) (function) of namespace syclinit is not documented.
+ src/shamsys/src/NodeInstance.cpp:344: warning: Member get_compute_scheduler() (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:344: warning: Member get_compute_scheduler() (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:346: warning: Member get_alt_scheduler() (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:346: warning: Member get_alt_scheduler() (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:348: warning: Member get_compute_scheduler_ptr() (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:348: warning: Member get_compute_scheduler_ptr() (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:352: warning: Member get_alt_scheduler_ptr() (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:352: warning: Member get_alt_scheduler_ptr() (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:354: warning: Member print_device_info(const sycl::device &Device) (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:361: warning: Member print_device_list() (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:361: warning: Member print_device_list() (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:367: warning: Member print_mpi_capabilities() (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:367: warning: Member print_mpi_capabilities() (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:369: warning: Member check_dgpu_available() (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:369: warning: Member check_dgpu_available() (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:397: warning: Member init_queues(u32 alt_id, u32 compute_id) (function) of namespace syclinit is not documented.
- src/shamsys/src/NodeInstance.cpp:454: warning: Member finalize() (function) of namespace syclinit is not documented.
- src/shamsys/src/NodeInstance.cpp:46: warning: Member SHAMLOGFORMATTER (variable) of file NodeInstance.cpp is not documented.
- src/shamsys/src/NodeInstance.cpp:470: warning: Member compute_queue_eu_count (variable) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:472: warning: Member get_compute_queue_eu_count(u32 id=0) (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:472: warning: Member get_compute_queue_eu_count(u32 id=0) (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:480: warning: Member print_queue_map() (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:480: warning: Member print_queue_map() (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:49: warning: Member SHAMLOG_ERR_ON_EXCEPT (variable) of file NodeInstance.cpp is not documented.
- src/shamsys/src/NodeInstance.cpp:518: warning: Member print_device_list_debug() (function) of namespace shamsys::instance::tmp is not documented.
+ src/shamsys/src/NodeInstance.cpp:51: warning: Member print_device_list() (function) of namespace shamsys::instance::details is not documented.
- src/shamsys/src/NodeInstance.cpp:615: warning: Member start_mpi(MPIInitInfo mpi_info) (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:707: warning: Member init_auto(std::string search_key, MPIInitInfo mpi_info) (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:707: warning: Member init_auto(std::string search_key, MPIInitInfo mpi_info) (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:735: warning: Member get_compute_scheduler() (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:735: warning: Member get_compute_scheduler() (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:737: warning: Member get_alt_scheduler() (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:737: warning: Member get_alt_scheduler() (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:739: warning: Member get_compute_scheduler_ptr() (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:739: warning: Member get_compute_scheduler_ptr() (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:743: warning: Member get_alt_scheduler_ptr() (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:743: warning: Member get_alt_scheduler_ptr() (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:745: warning: Member print_device_info(const sycl::device &Device) (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:752: warning: Member print_device_list() (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:752: warning: Member print_device_list() (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:768: warning: Member start_sycl_auto(std::string search_key) (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:768: warning: Member start_sycl_auto(std::string search_key) (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:782: warning: Member print_mpi_capabilities() (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:782: warning: Member print_mpi_capabilities() (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:784: warning: Member check_dgpu_available() (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:784: warning: Member check_dgpu_available() (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:96: warning: Member initialized (variable) of namespace syclinit is not documented.
+ src/shamsys/src/NodeInstance.cpp:98: warning: Member device_compute (variable) of namespace syclinit is not documented.
+ src/shamsys/src/NodeInstance.cpp:99: warning: Member device_alt (variable) of namespace syclinit is not documented.
+ src/shamsys/src/change_log_format.cpp:203: warning: Member SHAMLOGFORMATTER (variable) of file change_log_format.cpp is not documented.
+ src/shamsys/src/change_log_format.cpp:206: warning: Member SHAMLOG_ERR_ON_EXCEPT (variable) of file change_log_format.cpp is not documented.
+ src/shamsys/src/device_select.cpp:105: warning: Member init_queues(u32 alt_id, u32 compute_id) (function) of file device_select.cpp is not documented.
+ src/shamsys/src/device_select.cpp:26: warning: Member init_queues_auto(std::string search_key) (function) of file device_select.cpp is not documented.

@tdavidcl tdavidcl merged commit 8f016c7 into main Mar 1, 2025
@tdavidcl tdavidcl deleted the feat/sham-smi branch March 1, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Main] add shamrock -smi option to list device [main] --sycl-ls option should work regardless of the other input

1 participant