Skip to content

[Algs] improve group reduction switching for acpp SSCP backend#881

Merged
tdavidcl merged 7 commits intoShamrock-code:mainfrom
tdavidcl:feat/improve-sscp-switches
Mar 28, 2025
Merged

[Algs] improve group reduction switching for acpp SSCP backend#881
tdavidcl merged 7 commits intoShamrock-code:mainfrom
tdavidcl:feat/improve-sscp-switches

Conversation

@tdavidcl
Copy link
Copy Markdown
Member

No description provided.

@tdavidcl tdavidcl marked this pull request as ready for review March 25, 2025 18:00
@github-actions
Copy link
Copy Markdown
Contributor

Workflow report

workflow report corresponding to commit d4c6f45
Commiter email is timothee.davidcleris@proton.me

Pre-commit check report

Pre-commit check: ✅

[WARNING] The 'rev' field of repo 'https://github.com/psf/black' appears to be a mutable reference (moving tag / branch).  Mutable references are never updated after first install and are not supported.  See https://pre-commit.com/#using-the-latest-version-for-a-repository for more details.  Hint: `pre-commit autoupdate` often fixes this.
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check yaml...............................................................Passed
detect private key.......................................................Passed
Validate GitHub Workflows................................................Passed
clang-format.............................................................Passed
black....................................................................Passed
isort....................................................................Passed
Check doxygen headers....................................................Passed
Check license headers....................................................Passed
Check #pragma once.......................................................Passed
Check SYCL #include......................................................Passed

Test pipeline can run.

Clang-tidy diff report

No relevant changes found.
Well done!

You should now go back to your normal life and enjoy a hopefully sunny day while waiting for the review.

Doxygen diff with main

Removed warnings : 23
New warnings : 20
Warnings count : 5696 → 5693 (-0.1%)

Detailed changes :
- src/shamalgs/include/shamalgs/details/reduction/groupReduction.hpp:38: warning: Compound shamalgs::reduction::details::GroupReduction is not documented.
- src/shamalgs/include/shamalgs/details/reduction/groupReduction.hpp:40: warning: Member sum(sycl::queue &q, sycl::buffer< T > &buf1, u32 start_id, u32 end_id) (function) of struct shamalgs::reduction::details::GroupReduction is not documented.
- src/shamalgs/include/shamalgs/details/reduction/groupReduction.hpp:42: warning: Member min(sycl::queue &q, sycl::buffer< T > &buf1, u32 start_id, u32 end_id) (function) of struct shamalgs::reduction::details::GroupReduction is not documented.
- src/shamalgs/include/shamalgs/details/reduction/groupReduction.hpp:44: warning: Member max(sycl::queue &q, sycl::buffer< T > &buf1, u32 start_id, u32 end_id) (function) of struct shamalgs::reduction::details::GroupReduction is not documented.
+ src/shamalgs/src/details/numeric/numeric.cpp:54: warning: Member inclusive_sum(sycl::queue &q, sycl::buffer< T > &buf1, u32 len) (function) of namespace shamalgs::numeric is not documented.
+ src/shamalgs/src/details/numeric/numeric.cpp:54: warning: Member inclusive_sum(sycl::queue &q, sycl::buffer< T > &buf1, u32 len) (function) of namespace shamalgs::numeric is not documented.
+ src/shamalgs/src/details/numeric/numeric.cpp:54: warning: Member inclusive_sum(sycl::queue &q, sycl::buffer< T > &buf1, u32 len) (function) of namespace shamalgs::numeric is not documented.
- src/shamalgs/src/details/numeric/numeric.cpp:56: warning: Member inclusive_sum(sycl::queue &q, sycl::buffer< T > &buf1, u32 len) (function) of namespace shamalgs::numeric is not documented.
- src/shamalgs/src/details/numeric/numeric.cpp:56: warning: Member inclusive_sum(sycl::queue &q, sycl::buffer< T > &buf1, u32 len) (function) of namespace shamalgs::numeric is not documented.
- src/shamalgs/src/details/numeric/numeric.cpp:56: warning: Member inclusive_sum(sycl::queue &q, sycl::buffer< T > &buf1, u32 len) (function) of namespace shamalgs::numeric is not documented.
+ src/shamalgs/src/details/numeric/numeric.cpp:59: warning: Member exclusive_sum_in_place(sycl::queue &q, sycl::buffer< T > &buf, u32 len) (function) of namespace shamalgs::numeric is not documented.
+ src/shamalgs/src/details/numeric/numeric.cpp:59: warning: Member exclusive_sum_in_place(sycl::queue &q, sycl::buffer< T > &buf, u32 len) (function) of namespace shamalgs::numeric is not documented.
+ src/shamalgs/src/details/numeric/numeric.cpp:59: warning: Member exclusive_sum_in_place(sycl::queue &q, sycl::buffer< T > &buf, u32 len) (function) of namespace shamalgs::numeric is not documented.
- src/shamalgs/src/details/numeric/numeric.cpp:61: warning: Member exclusive_sum_in_place(sycl::queue &q, sycl::buffer< T > &buf, u32 len) (function) of namespace shamalgs::numeric is not documented.
- src/shamalgs/src/details/numeric/numeric.cpp:61: warning: Member exclusive_sum_in_place(sycl::queue &q, sycl::buffer< T > &buf, u32 len) (function) of namespace shamalgs::numeric is not documented.
- src/shamalgs/src/details/numeric/numeric.cpp:61: warning: Member exclusive_sum_in_place(sycl::queue &q, sycl::buffer< T > &buf, u32 len) (function) of namespace shamalgs::numeric is not documented.
+ src/shamalgs/src/details/numeric/numeric.cpp:64: warning: Member inclusive_sum_in_place(sycl::queue &q, sycl::buffer< T > &buf, u32 len) (function) of namespace shamalgs::numeric is not documented.
+ src/shamalgs/src/details/numeric/numeric.cpp:64: warning: Member inclusive_sum_in_place(sycl::queue &q, sycl::buffer< T > &buf, u32 len) (function) of namespace shamalgs::numeric is not documented.
+ src/shamalgs/src/details/numeric/numeric.cpp:64: warning: Member inclusive_sum_in_place(sycl::queue &q, sycl::buffer< T > &buf, u32 len) (function) of namespace shamalgs::numeric is not documented.
- src/shamalgs/src/details/numeric/numeric.cpp:66: warning: Member inclusive_sum_in_place(sycl::queue &q, sycl::buffer< T > &buf, u32 len) (function) of namespace shamalgs::numeric is not documented.
- src/shamalgs/src/details/numeric/numeric.cpp:66: warning: Member inclusive_sum_in_place(sycl::queue &q, sycl::buffer< T > &buf, u32 len) (function) of namespace shamalgs::numeric is not documented.
- src/shamalgs/src/details/numeric/numeric.cpp:66: warning: Member inclusive_sum_in_place(sycl::queue &q, sycl::buffer< T > &buf, u32 len) (function) of namespace shamalgs::numeric is not documented.
+ src/shamalgs/src/details/numeric/numeric.cpp:68: warning: Member exclusive_sum(sycl::queue &q, sycl::buffer< u32 > &buf1, u32 len) (function) of namespace shamalgs::numeric is not documented.
+ src/shamalgs/src/details/numeric/numeric.cpp:68: warning: Member exclusive_sum(sycl::queue &q, sycl::buffer< u32 > &buf1, u32 len) (function) of namespace shamalgs::numeric is not documented.
+ src/shamalgs/src/details/numeric/numeric.cpp:70: warning: Member exclusive_sum(sham::DeviceScheduler_ptr sched, sham::DeviceBuffer< u32 > &buf1, u32 len) (function) of namespace shamalgs::numeric is not documented.
+ src/shamalgs/src/details/numeric/numeric.cpp:70: warning: Member exclusive_sum(sham::DeviceScheduler_ptr sched, sham::DeviceBuffer< u32 > &buf1, u32 len) (function) of namespace shamalgs::numeric is not documented.
- src/shamalgs/src/details/numeric/numeric.cpp:70: warning: Member exclusive_sum(sycl::queue &q, sycl::buffer< u32 > &buf1, u32 len) (function) of namespace shamalgs::numeric is not documented.
- src/shamalgs/src/details/numeric/numeric.cpp:70: warning: Member exclusive_sum(sycl::queue &q, sycl::buffer< u32 > &buf1, u32 len) (function) of namespace shamalgs::numeric is not documented.
+ src/shamalgs/src/details/numeric/numeric.cpp:71: warning: Member inclusive_sum(sycl::queue &q, sycl::buffer< u32 > &buf1, u32 len) (function) of namespace shamalgs::numeric is not documented.
+ src/shamalgs/src/details/numeric/numeric.cpp:71: warning: Member inclusive_sum(sycl::queue &q, sycl::buffer< u32 > &buf1, u32 len) (function) of namespace shamalgs::numeric is not documented.
- src/shamalgs/src/details/numeric/numeric.cpp:72: warning: Member exclusive_sum(sham::DeviceScheduler_ptr sched, sham::DeviceBuffer< u32 > &buf1, u32 len) (function) of namespace shamalgs::numeric is not documented.
- src/shamalgs/src/details/numeric/numeric.cpp:72: warning: Member exclusive_sum(sham::DeviceScheduler_ptr sched, sham::DeviceBuffer< u32 > &buf1, u32 len) (function) of namespace shamalgs::numeric is not documented.
+ src/shamalgs/src/details/numeric/numeric.cpp:73: warning: Member exclusive_sum_in_place(sycl::queue &q, sycl::buffer< u32 > &buf1, u32 len) (function) of namespace shamalgs::numeric is not documented.
+ src/shamalgs/src/details/numeric/numeric.cpp:73: warning: Member exclusive_sum_in_place(sycl::queue &q, sycl::buffer< u32 > &buf1, u32 len) (function) of namespace shamalgs::numeric is not documented.
- src/shamalgs/src/details/numeric/numeric.cpp:73: warning: Member inclusive_sum(sycl::queue &q, sycl::buffer< u32 > &buf1, u32 len) (function) of namespace shamalgs::numeric is not documented.
- src/shamalgs/src/details/numeric/numeric.cpp:73: warning: Member inclusive_sum(sycl::queue &q, sycl::buffer< u32 > &buf1, u32 len) (function) of namespace shamalgs::numeric is not documented.
+ src/shamalgs/src/details/numeric/numeric.cpp:74: warning: Member inclusive_sum_in_place(sycl::queue &q, sycl::buffer< u32 > &buf1, u32 len) (function) of namespace shamalgs::numeric is not documented.
+ src/shamalgs/src/details/numeric/numeric.cpp:74: warning: Member inclusive_sum_in_place(sycl::queue &q, sycl::buffer< u32 > &buf1, u32 len) (function) of namespace shamalgs::numeric is not documented.
- src/shamalgs/src/details/numeric/numeric.cpp:75: warning: Member exclusive_sum_in_place(sycl::queue &q, sycl::buffer< u32 > &buf1, u32 len) (function) of namespace shamalgs::numeric is not documented.
- src/shamalgs/src/details/numeric/numeric.cpp:75: warning: Member exclusive_sum_in_place(sycl::queue &q, sycl::buffer< u32 > &buf1, u32 len) (function) of namespace shamalgs::numeric is not documented.
- src/shamalgs/src/details/numeric/numeric.cpp:76: warning: Member inclusive_sum_in_place(sycl::queue &q, sycl::buffer< u32 > &buf1, u32 len) (function) of namespace shamalgs::numeric is not documented.
- src/shamalgs/src/details/numeric/numeric.cpp:76: warning: Member inclusive_sum_in_place(sycl::queue &q, sycl::buffer< u32 > &buf1, u32 len) (function) of namespace shamalgs::numeric is not documented.

@tdavidcl tdavidcl merged commit 5b917fe into Shamrock-code:main Mar 28, 2025
31 checks passed
@tdavidcl tdavidcl deleted the feat/improve-sscp-switches branch March 28, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant