Skip to content

[Pre-commit] update precommit modules#885

Merged
tdavidcl merged 7 commits intoShamrock-code:mainfrom
tdavidcl:precomm-update
Mar 29, 2025
Merged

[Pre-commit] update precommit modules#885
tdavidcl merged 7 commits intoShamrock-code:mainfrom
tdavidcl:precomm-update

Conversation

@tdavidcl
Copy link
Copy Markdown
Member

@tdavidcl tdavidcl commented Mar 28, 2025

TODO: add precommit log entry for ci

@tdavidcl tdavidcl added the draft label Mar 28, 2025
@tdavidcl tdavidcl linked an issue Mar 28, 2025 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown
Contributor

Workflow report

workflow report corresponding to commit 08944ca
Commiter email is timothee.davidcleris@proton.me

Pre-commit check report

Pre-commit check: ✅

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check for broken symlinks............................(no files to check)Skipped
check yaml...............................................................Passed
detect private key.......................................................Passed
No-tabs checker..........................................................Passed
Tabs remover.............................................................Passed
Validate GitHub Workflows................................................Passed
clang-format.............................................................Passed
black....................................................................Passed
isort....................................................................Passed
Check doxygen headers....................................................Passed
Check license headers....................................................Passed
Check #pragma once.......................................................Passed
Check SYCL #include......................................................Passed

Test pipeline can run.

Clang-tidy diff report

No relevant changes found.
Well done!

You should now go back to your normal life and enjoy a hopefully sunny day while waiting for the review.

Doxygen diff with main

Removed warnings : 3
New warnings : 3
Warnings count : 5693 → 5693 (0.0%)

Detailed changes :
+ src/shamtree/src/RadixTree.cpp:309: warning: Member print_member(const T &a) (function) of file RadixTree.cpp is not documented.
- src/shamtree/src/RadixTree.cpp:310: warning: Member print_member(const T &a) (function) of file RadixTree.cpp is not documented.
+ src/shamtree/src/RadixTree.cpp:312: warning: Member print_member(const u8 &a) (function) of file RadixTree.cpp is not documented.
- src/shamtree/src/RadixTree.cpp:313: warning: Member print_member(const u8 &a) (function) of file RadixTree.cpp is not documented.
+ src/shamtree/src/RadixTree.cpp:317: warning: Member print_member(const u32 &a) (function) of file RadixTree.cpp is not documented.
- src/shamtree/src/RadixTree.cpp:318: warning: Member print_member(const u32 &a) (function) of file RadixTree.cpp is not documented.

@tdavidcl tdavidcl marked this pull request as ready for review March 29, 2025 09:52
@tdavidcl tdavidcl added in-review and removed draft labels Mar 29, 2025
@tdavidcl tdavidcl merged commit 0a27c65 into Shamrock-code:main Mar 29, 2025
31 checks passed
@tdavidcl tdavidcl deleted the precomm-update branch March 29, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Pre-commit] Pin black version

1 participant