Skip to content

[Tree] allow constructing ReducedMortonSet from cached buffers#906

Merged
tdavidcl merged 2 commits intoShamrock-code:mainfrom
tdavidcl:feat/allow-cache-call-reduced-mortonset
Apr 9, 2025
Merged

[Tree] allow constructing ReducedMortonSet from cached buffers#906
tdavidcl merged 2 commits intoShamrock-code:mainfrom
tdavidcl:feat/allow-cache-call-reduced-mortonset

Conversation

@tdavidcl
Copy link
Copy Markdown
Member

@tdavidcl tdavidcl commented Apr 8, 2025

No description provided.

@tdavidcl tdavidcl added the draft label Apr 8, 2025
@tdavidcl tdavidcl marked this pull request as ready for review April 9, 2025 07:08
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2025

Workflow report

workflow report corresponding to commit 63b8d2e
Commiter email is timothee.davidcleris@proton.me

Pre-commit check report

Pre-commit check: ✅

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check for broken symlinks............................(no files to check)Skipped
check yaml...............................................................Passed
detect private key.......................................................Passed
No-tabs checker..........................................................Passed
Tabs remover.............................................................Passed
Validate GitHub Workflows................................................Passed
clang-format.............................................................Passed
black....................................................................Passed
isort....................................................................Passed
Check doxygen headers....................................................Passed
Check license headers....................................................Passed
Check #pragma once.......................................................Passed
Check SYCL #include......................................................Passed

Test pipeline can run.

Clang-tidy diff report

No relevant changes found.
Well done!

You should now go back to your normal life and enjoy a hopefully sunny day while waiting for the review.

Doxygen diff with main

Removed warnings : 4
New warnings : 6
Warnings count : 5726 → 5728 (0.0%)

Detailed changes :
- src/shamtree/src/MortonReducedSet.cpp:74: warning: no matching file member found for 
- src/shamtree/src/MortonReducedSet.cpp:78: warning: no matching file member found for 
+ src/shamtree/src/MortonReducedSet.cpp:94: warning: no matching file member found for 
+ src/shamtree/src/MortonReducedSet.cpp:98: warning: no matching file member found for 

@tdavidcl tdavidcl merged commit feb1e69 into Shamrock-code:main Apr 9, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant