Skip to content

[Env] Allow installing shamrock executable with pip#912

Merged
tdavidcl merged 10 commits intoShamrock-code:mainfrom
tdavidcl:feat/python-exe
Apr 13, 2025
Merged

[Env] Allow installing shamrock executable with pip#912
tdavidcl merged 10 commits intoShamrock-code:mainfrom
tdavidcl:feat/python-exe

Conversation

@tdavidcl
Copy link
Copy Markdown
Member

Allow installing shamrock executable with pip

This PR finally implement a way to install both the pylib and the executable when using pip install (thanks to the solution provided in pypa/setuptools#210 (comment)).

Additionally _pysetup.py was moved to env helpers.

Lastly, this PR removes --pylib and will systematically copy setup.py to the builddir if the env supports it.

@tdavidcl tdavidcl added the draft label Apr 12, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Workflow report

workflow report corresponding to commit 715d92e
Commiter email is timothee.davidcleris@proton.me

Pre-commit check report

Pre-commit check: ✅

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check for broken symlinks............................(no files to check)Skipped
check yaml...............................................................Passed
detect private key.......................................................Passed
No-tabs checker..........................................................Passed
Tabs remover.............................................................Passed
Validate GitHub Workflows................................................Passed
clang-format.............................................................Passed
black....................................................................Passed
isort....................................................................Passed
Check doxygen headers....................................................Passed
Check license headers....................................................Passed
Check #pragma once.......................................................Passed
Check SYCL #include......................................................Passed

Test pipeline can run.

Clang-tidy diff report

No relevant changes found.
Well done!

You should now go back to your normal life and enjoy a hopefully sunny day while waiting for the review.

Doxygen diff with main

Removed warnings : 0
New warnings : 0
Warnings count : 5736 → 5736 (0.0%)

Detailed changes :

@tdavidcl tdavidcl marked this pull request as ready for review April 13, 2025 15:44
@tdavidcl tdavidcl added in-review and removed draft labels Apr 13, 2025
@tdavidcl tdavidcl merged commit f195ac6 into Shamrock-code:main Apr 13, 2025
33 checks passed
@tdavidcl tdavidcl deleted the feat/python-exe branch April 13, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant