[Backends] detect physical memory size & correct it on acpp OpenMP backend#935
Merged
tdavidcl merged 3 commits intoShamrock-code:mainfrom Apr 27, 2025
Merged
Conversation
Contributor
Workflow reportworkflow report corresponding to commit dd3d579 Pre-commit check reportPre-commit check: ✅ Test pipeline can run. Clang-tidy diff reportNo relevant changes found. You should now go back to your normal life and enjoy a hopefully sunny day while waiting for the review. Doxygen diff with
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see : AdaptiveCpp/AdaptiveCpp#1573
On acpp OpenMP backend the global memory size report something huge (2^64 -1) so we need to correct it if we want to use this value to test allocation size.
Also remove the use of
--sycl-lsand--sycl-ls-map.