Skip to content

[Backends] detect physical memory size & correct it on acpp OpenMP backend#935

Merged
tdavidcl merged 3 commits intoShamrock-code:mainfrom
tdavidcl:feat/get_phys_mem_size
Apr 27, 2025
Merged

[Backends] detect physical memory size & correct it on acpp OpenMP backend#935
tdavidcl merged 3 commits intoShamrock-code:mainfrom
tdavidcl:feat/get_phys_mem_size

Conversation

@tdavidcl
Copy link
Copy Markdown
Member

@tdavidcl tdavidcl commented Apr 27, 2025

see : AdaptiveCpp/AdaptiveCpp#1573

On acpp OpenMP backend the global memory size report something huge (2^64 -1) so we need to correct it if we want to use this value to test allocation size.

Also remove the use of --sycl-ls and --sycl-ls-map.

@github-actions
Copy link
Copy Markdown
Contributor

Workflow report

workflow report corresponding to commit dd3d579
Commiter email is timothee.davidcleris@proton.me

Pre-commit check report

Pre-commit check: ✅

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check for broken symlinks............................(no files to check)Skipped
check yaml...............................................................Passed
detect private key.......................................................Passed
No-tabs checker..........................................................Passed
Tabs remover.............................................................Passed
Validate GitHub Workflows................................................Passed
clang-format.............................................................Passed
black....................................................................Passed
isort....................................................................Passed
Check doxygen headers....................................................Passed
Check license headers....................................................Passed
Check #pragma once.......................................................Passed
Check SYCL #include......................................................Passed

Test pipeline can run.

Clang-tidy diff report

No relevant changes found.
Well done!

You should now go back to your normal life and enjoy a hopefully sunny day while waiting for the review.

Doxygen diff with main

Removed warnings : 0
New warnings : 0
Warnings count : 5731 → 5731 (0.0%)

Detailed changes :

@tdavidcl tdavidcl merged commit f83a174 into Shamrock-code:main Apr 27, 2025
34 checks passed
@tdavidcl tdavidcl deleted the feat/get_phys_mem_size branch April 27, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant