Skip to content

[Comm][Aurora pullback] improve MPI status log in startup#982

Merged
tdavidcl merged 1 commit intoShamrock-code:mainfrom
tdavidcl:pullback-aurora-1
May 18, 2025
Merged

[Comm][Aurora pullback] improve MPI status log in startup#982
tdavidcl merged 1 commit intoShamrock-code:mainfrom
tdavidcl:pullback-aurora-1

Conversation

@tdavidcl
Copy link
Copy Markdown
Member

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

Workflow report

workflow report corresponding to commit e88c574
Commiter email is timothee.davidcleris@proton.me
Github page artifact URL Github page articact link (can expire)

Pre-commit check report

Pre-commit check: ✅

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check for broken symlinks............................(no files to check)Skipped
check yaml...............................................................Passed
detect private key.......................................................Passed
No-tabs checker..........................................................Passed
Tabs remover.............................................................Passed
Validate GitHub Workflows................................................Passed
clang-format.............................................................Passed
black....................................................................Passed
isort....................................................................Passed
Check doxygen headers....................................................Passed
Check license headers....................................................Passed
Check #pragma once.......................................................Passed
Check SYCL #include......................................................Passed
No ssh in git submodules remote..........................................Passed

Test pipeline can run.

Clang-tidy diff report

No relevant changes found.
Well done!

You should now go back to your normal life and enjoy a hopefully sunny day while waiting for the review.

Doxygen diff with main

Removed warnings : 8
New warnings : 12
Warnings count : 5935 → 5939 (0.1%)

Detailed changes :
- src/shamcomm/src/mpiInfo.cpp:67: warning: Member _forced_state (variable) of namespace shamcomm is not documented.
- src/shamcomm/src/mpiInfo.cpp:67: warning: Member _forced_state (variable) of namespace shamcomm is not documented.
+ src/shamcomm/src/mpiInfo.cpp:68: warning: Member _forced_state (variable) of namespace shamcomm is not documented.
+ src/shamcomm/src/mpiInfo.cpp:68: warning: Member _forced_state (variable) of namespace shamcomm is not documented.
- src/shamcomm/src/worldInfo.cpp:24: warning: Member _world_rank (variable) of namespace shamcomm is not documented.
- src/shamcomm/src/worldInfo.cpp:24: warning: Member _world_rank (variable) of namespace shamcomm is not documented.
+ src/shamcomm/src/worldInfo.cpp:26: warning: Member _world_rank (variable) of namespace shamcomm is not documented.
+ src/shamcomm/src/worldInfo.cpp:26: warning: Member _world_rank (variable) of namespace shamcomm is not documented.
- src/shamcomm/src/worldInfo.cpp:26: warning: Member _world_size (variable) of namespace shamcomm is not documented.
- src/shamcomm/src/worldInfo.cpp:26: warning: Member _world_size (variable) of namespace shamcomm is not documented.
+ src/shamcomm/src/worldInfo.cpp:28: warning: Member _world_size (variable) of namespace shamcomm is not documented.
+ src/shamcomm/src/worldInfo.cpp:28: warning: Member _world_size (variable) of namespace shamcomm is not documented.
+ src/shamcomm/src/worldInfo.cpp:30: warning: Member _max_tag (variable) of namespace shamcomm is not documented.
+ src/shamcomm/src/worldInfo.cpp:30: warning: Member _max_tag (variable) of namespace shamcomm is not documented.
- src/shamsys/src/NodeInstance.cpp:387: warning: Member check_dgpu_available() (function) of namespace shamsys::instance is not documented.
- src/shamsys/src/NodeInstance.cpp:387: warning: Member check_dgpu_available() (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:387: warning: Member print_mpi_comm_info() (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:387: warning: Member print_mpi_comm_info() (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:389: warning: Member check_dgpu_available() (function) of namespace shamsys::instance is not documented.
+ src/shamsys/src/NodeInstance.cpp:389: warning: Member check_dgpu_available() (function) of namespace shamsys::instance is not documented.

@tdavidcl tdavidcl merged commit bdb636c into Shamrock-code:main May 18, 2025
38 checks passed
@tdavidcl tdavidcl deleted the pullback-aurora-1 branch May 18, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant