This repository was archived by the owner on Feb 21, 2024. It is now read-only.
fix: resolve image caching issue on flame_game template#143
Merged
alestiago merged 11 commits intoJan 30, 2024
Conversation
wolfenrain
reviewed
Jan 11, 2024
wolfenrain
reviewed
Jan 11, 2024
|
Thanks for the contribution! I left a few comments about the styling of the code itself so it fits with our overal practices. |
Contributor
|
Resolves #918 |
Contributor
Author
|
Tests have been updated as @wolfenrain suggested. |
alestiago
approved these changes
Jan 29, 2024
alestiago
left a comment
Contributor
There was a problem hiding this comment.
Made some minor adjustments to the tests, overall LGTM! Thank you for the contirbution 💙
wolfenrain
approved these changes
Jan 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Fixes: VeryGoodOpenSource/very_good_cli#918
There is a bug on the generated flame_game template. The cached images are not accessible from the FlameGame, therefore they are not "actually" cached and causing a runtime error. This pull request fixes the issue.
Type of Change