Skip to content

Use cache in check-dist.yml#369

Closed
jongwooo wants to merge 1 commit into
actions:mainfrom
jongwooo:chore/use-cache-in-check-dist
Closed

Use cache in check-dist.yml#369
jongwooo wants to merge 1 commit into
actions:mainfrom
jongwooo:chore/use-cache-in-check-dist

Conversation

@jongwooo
Copy link
Copy Markdown

@jongwooo jongwooo commented Dec 6, 2022

Signed-off-by: jongwooo jongwooo.han@gmail.com

Description

Use cache in check-dist.yml
See actions/cache#1004

AS-IS

- name: Set Node.js 12.x
  uses: actions/setup-node@v1
  with:
    node-version: 12.x

TO-BE

- name: Set Node.js 12.x
  uses: actions/setup-node@v3
  with:
    node-version: 12.x
    cache: npm

It’s literally a one line change to pass the cache: npm input parameter.

@jongwooo jongwooo requested a review from a team as a code owner December 6, 2022 16:10
Signed-off-by: jongwooo <jongwooo.han@gmail.com>
@konradpabjan
Copy link
Copy Markdown
Contributor

Thanks for the PR but we've recently added caching in a separate PR while me migrated to node 16 so these changes are no longer needed

- name: Setup Node 16
uses: actions/setup-node@v3
with:
node-version: 16.x
cache: 'npm'

@jongwooo jongwooo deleted the chore/use-cache-in-check-dist branch January 5, 2023 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants