Update AeronArchive configuration to make retry attempts configurable.#1852
Closed
thughescmc wants to merge 1 commit intoaeron-io:masterfrom
Closed
Conversation
…DEFAULT_RETRY_ATTEMPTS` and replace references with `MESSAGE_RETRY_ATTEMPTS_DEFAULT` in `ArchiveProxy` and `AeronArchive`.
Contributor
|
Looks good to me. @vyazelenko WDYT? @thughescmc could you rebase? |
Contributor
|
@thughescmc could you rebase? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new configuration property for controlling the number of retry attempts when offering requests to the Aeron Archive, moving this setting from
ArchiveProxyto the main configuration. It also updates the usage and documentation to reflect this change, deprecates the old constant inArchiveProxy, and ensures that the value is configurable via the context and system properties.