Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #17570 +/- ##
============================================
+ Coverage 39.88% 39.97% +0.08%
Complexity 2547 2547
============================================
Files 5172 5173 +1
Lines 348236 348388 +152
Branches 44497 44528 +31
============================================
+ Hits 138899 139266 +367
+ Misses 209337 209122 -215 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Write failure issue:
* If the creation of TsFileProcessor fails, it may be treated as a successful return, resulting in silent data loss.
* Failed writes will still update the last cache, and the memory state may be ahead of the actual write.
* When InsertRows retries after a DataTypeInconsistentException, it fails to re-distribute seq/unseq for each row, potentially resulting in some rows being overwritten to the wrong processor.
* The failure callback for InsertRows/InsertRowsOfOneDevice may result in missed reports.
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR