[LIBCLOUD-640] Add support for Softlayer DNS driver#413
Closed
vanclevstik wants to merge 1 commit into
Closed
Conversation
2007cc9 to
81e844d
Compare
Member
|
Great, thanks. I will review it ASAP. As far as |
81e844d to
9be2d8b
Compare
Contributor
Author
|
Had some Travis fails on py3 builds, should be fine now. |
Member
There was a problem hiding this comment.
Minor style and consistency things - can you please re-order the methods and put "private" methods at the end (https://libcloud.readthedocs.org/en/latest/development.html#function-and-method-ordering)?
9be2d8b to
0e76368
Compare
Contributor
Author
|
@Kami Fixed, ready for review :) |
Member
|
I've made some more missed changes (updated Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Driver has been tested a bit manually too and it seems to work. Looking for review/any comments
One thing missing is support for "update_zone" method as SoftLayer doesn't support so I don't really know how to tackle this problem?