Skip to content

Fixed GCE.ex_get_image to work on projects with > 500 images. #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
crunk1 wants to merge 1 commit into from
Closed

Fixed GCE.ex_get_image to work on projects with > 500 images. #939

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions libcloud/compute/drivers/gce.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7326,16 +7326,18 @@ def _match_images(self, project, partial_name):
if no matching image is found.
:rtype: :class:`GCENodeImage` or ``None``
"""
project_images = self.list_images(ex_project=project,
ex_include_deprecated=True)
project_images_pages = self.ex_list(
self.list_images, ex_project=project, ex_include_deprecated=True)
partial_match = []
for image in project_images:
if image.name == partial_name:
return image
if image.name.startswith(partial_name):
ts = timestamp_to_datetime(image.extra['creationTimestamp'])
if not partial_match or partial_match[0] < ts:
partial_match = [ts, image]
for page in project_images_pages:
for image in page:
if image.name == partial_name:
return image
if image.name.startswith(partial_name):
ts = timestamp_to_datetime(
image.extra['creationTimestamp'])
if not partial_match or partial_match[0] < ts:
partial_match = [ts, image]

if partial_match:
return partial_match[1]
Expand Down