Fix the bug that created the node at ecs driver and implement the method for creating public ip #943
Closed
watermelo wants to merge 3 commits into
Closed
Fix the bug that created the node at ecs driver and implement the method for creating public ip #943watermelo wants to merge 3 commits into
watermelo wants to merge 3 commits into
Conversation
1, From the official document can know parameter param['IoOptimized'] type is string and his value is ``none`` or ``optimized``
Member
Author
|
Looks like there is a problem in unit test, I need to modify the unit test . |
Member
|
Thanks! The change looks good to me. |
Member
Author
|
hi!~ @Kami , I have modified the unit test |
Member
Author
|
Sorry, I'm not too familiar with github to cause no new branches to make a second commit. T.T |
Contributor
|
👍 thanks @watermelo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Title (replace this with a logical title for your changes)
Description
1, From the official document can know parameter param['IoOptimized'] type is string and his value is
noneoroptimizedOfficial document:
https://help.aliyun.com/document_detail/25499.html?spm=5176.doc25513.6.255.IAZjXA
2, Amend commit:
Implement the method for creating public ip.
Status
Checklist (tick everything that applies)