Implement BitSetIterator#docIDRunEnd#16072
Open
iverase wants to merge 3 commits into
Open
Conversation
benwtrent
reviewed
May 15, 2026
Member
benwtrent
left a comment
There was a problem hiding this comment.
Need a CHANGES entry under optimizations I would think
| } while (aa != DocIdSetIterator.NO_MORE_DOCS); | ||
| } | ||
|
|
||
| void doNextClearBit(java.util.BitSet a, FixedBitSet b) { |
Member
There was a problem hiding this comment.
Maybe I am misunderstanding how FixedbitSet is tested, but I would expect something like we have in the sparse tests with testNextClearBit with random inputs matching up the brute-force next clear bit set.
Contributor
Author
There was a problem hiding this comment.
This test is mimicking the implementation of #doNextSetBit so it is how FixedBitSet is tested.
# Conflicts: # lucene/CHANGES.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to make it efficient, i added a new method to the BitSet interface called #nextClearBit which is implemented for the subclasses.