[release][Dont Squash] Update version to 0.24.0 and 0.25.dev0 on main branch#18964
[release][Dont Squash] Update version to 0.24.0 and 0.25.dev0 on main branch#18964OmarAzizi wants to merge 2 commits intoapache:mainfrom
Conversation
Signed-off-by: OmarAzizi <oalazizi75@gmail.com>
There was a problem hiding this comment.
Code Review
This pull request updates the project version from 0.24.dev0 to 0.25.dev0 across several files, including C++ headers, Python configuration, and web package manifests. Feedback was provided regarding the version format in the web-related files (package.json and package-lock.json), as the proposed 0.25.dev0 string violates npm's SemVer requirements and should be adjusted to 0.25.0-dev0 for consistency and compatibility.
| "license": "Apache-2.0", | ||
| "homepage": "https://github.com/apache/tvm/tree/main/web", | ||
| "version": "0.24.0-dev2", | ||
| "version": "0.25.dev0", |
There was a problem hiding this comment.
The version string for npm packages must follow the SemVer format. The current value 0.25.dev0 is invalid for npm and inconsistent with the project's versioning convention defined in version.py (lines 198-199), which transforms development versions into the X.Y.0-devN format. It should be 0.25.0-dev0. It is recommended to run python version.py to ensure all version strings are correctly synchronized across the repository.
| "version": "0.25.dev0", | |
| "version": "0.25.0-dev0", |
| { | ||
| "name": "tvmjs", | ||
| "version": "0.24.0-dev2", | ||
| "version": "0.25.dev0", |
| "": { | ||
| "name": "tvmjs", | ||
| "version": "0.24.0-dev2", | ||
| "version": "0.25.dev0", |
8ec9cd2 to
8b43a92
Compare
JiwaniZakir
left a comment
There was a problem hiding this comment.
The version bump is consistent across Python (pyproject.toml, libinfo.py, version.py) and C (include/tvm/runtime/base.h), which is good. One thing worth flagging: the npm package in web/package.json was at 0.24.0-dev2 before this PR, meaning it had gone through at least two dev iterations — resetting to 0.25.0-dev0 is expected, but it's worth confirming package-lock.json was regenerated via npm install rather than edited by hand, since manual edits to lock files can silently drift from the actual resolved dependency tree. The PR title mentions updating to both 0.24.0 (release) and 0.25.dev0 (main), but the diff only reflects the 0.25.dev0 side — if the 0.24.0 changes live on the release branch, it would be helpful to link that branch or PR for traceability. Finally, version.py has a comment stating "The following line is set by version.py" implying a scripted update mechanism, so it's worth verifying all four version sites (base.h, pyproject.toml, libinfo.py, version.py) are covered by that script rather than relying on manual edits each release cycle.
Make version modification twice as two commits:
NOTE: Don't squash when merge.
Ref: #18921 (release schedule)
Following same pattern as #18669