Skip to content

[release][Dont Squash] Update version to 0.24.0 and 0.25.dev0 on main branch#18964

Closed
OmarAzizi wants to merge 2 commits intoapache:mainfrom
OmarAzizi:release/v0.24.0-version-bump
Closed

[release][Dont Squash] Update version to 0.24.0 and 0.25.dev0 on main branch#18964
OmarAzizi wants to merge 2 commits intoapache:mainfrom
OmarAzizi:release/v0.24.0-version-bump

Conversation

@OmarAzizi
Copy link
Copy Markdown
Contributor

Make version modification twice as two commits:

  • First, to v0.24.0 on main branch.
  • Second, to v0.25.dev0 on main branch in one PR.

NOTE: Don't squash when merge.

Ref: #18921 (release schedule)
Following same pattern as #18669

Signed-off-by: OmarAzizi <oalazizi75@gmail.com>
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the project version from 0.24.dev0 to 0.25.dev0 across several files, including C++ headers, Python configuration, and web package manifests. Feedback was provided regarding the version format in the web-related files (package.json and package-lock.json), as the proposed 0.25.dev0 string violates npm's SemVer requirements and should be adjusted to 0.25.0-dev0 for consistency and compatibility.

Comment thread web/package.json Outdated
"license": "Apache-2.0",
"homepage": "https://github.com/apache/tvm/tree/main/web",
"version": "0.24.0-dev2",
"version": "0.25.dev0",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The version string for npm packages must follow the SemVer format. The current value 0.25.dev0 is invalid for npm and inconsistent with the project's versioning convention defined in version.py (lines 198-199), which transforms development versions into the X.Y.0-devN format. It should be 0.25.0-dev0. It is recommended to run python version.py to ensure all version strings are correctly synchronized across the repository.

Suggested change
"version": "0.25.dev0",
"version": "0.25.0-dev0",

Comment thread web/package-lock.json Outdated
{
"name": "tvmjs",
"version": "0.24.0-dev2",
"version": "0.25.dev0",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This version string should be updated to 0.25.0-dev0 to match the corrected version in package.json and adhere to the npm SemVer requirements.

Suggested change
"version": "0.25.dev0",
"version": "0.25.0-dev0",

Comment thread web/package-lock.json Outdated
"": {
"name": "tvmjs",
"version": "0.24.0-dev2",
"version": "0.25.dev0",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This version string should be updated to 0.25.0-dev0 to match the corrected version in package.json and adhere to the npm SemVer requirements.

Suggested change
"version": "0.25.dev0",
"version": "0.25.0-dev0",

@OmarAzizi OmarAzizi force-pushed the release/v0.24.0-version-bump branch from 8ec9cd2 to 8b43a92 Compare April 1, 2026 12:50
Copy link
Copy Markdown
Contributor

@JiwaniZakir JiwaniZakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version bump is consistent across Python (pyproject.toml, libinfo.py, version.py) and C (include/tvm/runtime/base.h), which is good. One thing worth flagging: the npm package in web/package.json was at 0.24.0-dev2 before this PR, meaning it had gone through at least two dev iterations — resetting to 0.25.0-dev0 is expected, but it's worth confirming package-lock.json was regenerated via npm install rather than edited by hand, since manual edits to lock files can silently drift from the actual resolved dependency tree. The PR title mentions updating to both 0.24.0 (release) and 0.25.dev0 (main), but the diff only reflects the 0.25.dev0 side — if the 0.24.0 changes live on the release branch, it would be helpful to link that branch or PR for traceability. Finally, version.py has a comment stating "The following line is set by version.py" implying a scripted update mechanism, so it's worth verifying all four version sites (base.h, pyproject.toml, libinfo.py, version.py) are covered by that script rather than relying on manual edits each release cycle.

@OmarAzizi OmarAzizi closed this Apr 8, 2026
@OmarAzizi OmarAzizi deleted the release/v0.24.0-version-bump branch April 8, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants